Closed Bug 942473 Opened 9 years ago Closed 9 years ago

Intermittent browser_styleeditor_pretty.js | Test timed out

Categories

(DevTools :: Style Editor, defect)

x86_64
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure)

https://tbpl.mozilla.org/php/getParsedLog.php?id=31000873&tree=Mozilla-Inbound
Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound opt test mochitest-browser-chrome on 2013-11-23 08:06:26 PST for push 5ecede5e0ceb
slave: talos-mtnlion-r5-044

08:28:43     INFO -  TEST-INFO | MEMORY STAT vsize after test: 4468256768
08:28:43     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 839000064
08:28:43     INFO -  TEST-INFO | MEMORY STAT heapAllocated after test: 242762992
08:28:43     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_nostyle.js | finished in 267ms
08:28:43     INFO -  TEST-INFO | checking window state
08:28:43     INFO -  TEST-START | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_pretty.js
08:28:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_pretty.js | Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0}]
08:28:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_pretty.js | Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0}]
08:28:43     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_pretty.js | minified source has been prettified automatically
08:28:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_pretty.js | Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0}]
08:28:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_pretty.js | Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0}]
(screenshot noise and screenshot)
08:29:19  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_pretty.js | Test timed out
08:29:19     INFO -  TEST-INFO | MEMORY STAT vsize after test: 4445102080
08:29:19     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 819679232
08:29:19     INFO -  TEST-INFO | MEMORY STAT heapAllocated after test: 182438648
08:29:19     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_pretty.js | finished in 30067ms
I have a patch in bug 931864 that unfortunately causes this test to time out a lot more frequently.  See 
  https://tbpl.mozilla.org/?tree=Try&rev=5e7f6477b3f4

This patch can change the timing of when async scripts are run and it already exposed a race condition in a different mochitest (bug 939643) that had previously failed a few times on tb so I'm guessing that is what is happening here.

The test looks pretty short, but I don't really understand it enough to spot a race condition.  By any chance could I get some help fixing this test (or, if the test isn't at fault, understanding what is going wrong)?  Alternatively, we could temporarily disable the test so that bug 931864 (which is somewhat time sensitive) could land.
Blocks: 931864
Sorry for the bother, but I was interested in landing my dependent patch soon (before next uplift) and I wanted to know what you think the best way forward is here.
Flags: needinfo?(fayearthur)
Actually, hg annotate indicates that cedricv landed these tests.  Perhaps you could provide some help?
Flags: needinfo?(cedricv)
Comparing a failing log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=31502727&tree=Try&full=1#error0
with a successful log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=31503100&tree=Try&full=1

It looks like the time out is happening after the
  "minified source has been prettified automatically"
test succeeds but before the "non-minified source has been left untouched" test gets to run.
Dave: you reviewed the landing of this test; do you mind if I temporarily disable it?
Flags: needinfo?(dcamp)
Sure, that should be ok.
Flags: needinfo?(dcamp)
Great, thanks!  For reference, the test is marked kkipped in:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d9356c6c769
Flags: needinfo?(fayearthur)
Flags: needinfo?(cedricv)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.