942483 - Port paint-dumping to android/b2g

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

I believe all we need to do print through printf_stderr which on android/b2g will go to logcat.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: b2g userconfig support

Comment 2

[Andreas Gal :gal]

Don't you always want to enable this? And maybe a prop you can set with adb setprop to actually show the output? Is the overhead too expensive?

Comment 3

[Benoit Girard (:BenWa)]

Let me see how much it adds to XUL

Comment 4

[Benoit Girard (:BenWa)]

Before: 26116792
After:  26145464
----------------
Diff:  +   28672

28k isn't big but it's also non trivial. It's a 0.1% increase.

Comment 5

[Andreas Gal :gal]

This is not usually loaded, right? I mean the pages with the code and strings. On disk is zip-ed. I would argue we can afford this, considering that it can be very useful for diagnosis.

Comment 6

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=2e8707010629

Comment 7

[Benoit Girard (:BenWa)]

Attachment: patch v2

fixed va_copy error on windows

Comment 8

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=697968d2b22a

Comment 9

[Benoit Girard (:BenWa)]

https://tbpl.mozilla.org/?tree=Try&rev=b5c39ab7ba15

Comment 10

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6a8c9ded5b0

Comment 11

[Benoit Girard (:BenWa)]

checkin-needed for b2g gonk-misc pull request.

Comment 12

[Andreas Gal :gal]

I merged the b2g gonk-misc pull request.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6a8c9ded5b0