Closed Bug 942483 Opened 6 years ago Closed 6 years ago

Port paint-dumping to android/b2g

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
I believe all we need to do print through printf_stderr which on android/b2g will go to logcat.
Attachment #8337300 - Flags: review?(matt.woodrow)
Attachment #8337300 - Flags: review?(matt.woodrow) → review+
Assignee: nobody → bgirard
Attached file b2g userconfig support
Attachment #8337336 - Flags: review?(gal)
Don't you always want to enable this? And maybe a prop you can set with adb setprop to actually show the output? Is the overhead too expensive?
Attachment #8337336 - Flags: review?(gal) → review+
Let me see how much it adds to XUL
Before: 26116792
After:  26145464
----------------
Diff:  +   28672

28k isn't big but it's also non trivial. It's a 0.1% increase.
This is not usually loaded, right? I mean the pages with the code and strings. On disk is zip-ed. I would argue we can afford this, considering that it can be very useful for diagnosis.
Attached patch patch v2Splinter Review
fixed va_copy error on windows
Attachment #8337300 - Attachment is obsolete: true
Attachment #8337429 - Flags: review+
checkin-needed for b2g gonk-misc pull request.
Keywords: checkin-needed
I merged the b2g gonk-misc pull request.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b6a8c9ded5b0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Depends on: 943110
Depends on: 944410
You need to log in before you can comment on or make changes to this bug.