94251 - Should change "Compact Folders" to text appropriate to account (IMAP, News)

Status: NEW

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Oliver Jones]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.3) Gecko/20010801
BuildID:    2001080104

Using IMAP in 'mark as deleted' mode.  The Compact Folders UI only removes
messages form the currently selected folder.  And as it effects a _single_
folder the language used in the UI should reflect this by using the singular
'Folder' as opposed to the plural 'Folders'.

Reproducible: Always
Steps to Reproduce:
1. Mark two messages in two seperate folders as deleted.
2. Use compact folders.


Actual Results:  Currently selected folder is compacted.

Expected Results:  From the wording you would expect all folders to be compacted.

Comment 1

[Keyser Sose]

Marking NEW.

Comment 2

[Andreas Premstaller]

In addition, the context menu correctly says "Compact This Folder". 

Comment 3

[Andreas Premstaller]

jglick, sspitzer: The spec at
http://www.mozilla.org/mailnews/specs/threepane/MailMenus.html
says the File menu item should be named "Compact Folders", and the context menu
item should be named "Compact This Folder". Both commands do the same thing,
namely compacting only the selected folder and not all folders of an account. 

Should the spec be changed to use "Compact This Folder" in both cases or are
there plans to implement "Compact (All) Folders" in the nearby future?

If only the wording should be changed, here comes the patch...

Comment 4

[Andreas Premstaller]

Attachment: Patch changing the wording and the label name (for consistency)

Comment 5

[Oliver Jones]

Can we also _please_ have a Keyboard shortcut or a tool bar item (like Outlook
express has "Purge").

Thanks

Comment 6

[Andreas Premstaller]

The spec does not contain a keyboard shortcut. I agree it would be useful.

jglick: Any chance to introduce one more shortcut into the spec?

Comment 7

[Oliver Jones]

Well Netscape Navigator 4 had one.  When you use IMAP in "Mark As Deleted" mode
it is used _a lot_ to clean up your folders.

Comment 8

[jglick]

Context menu for individual folders should be "Compact This Folder".

File menu item should be "Compact Folders", and it should do just that, compact 
All folders, but currently it does not. :-(   There should be a separate bug for 
that.

As for a shortcut, the problem is a shortage of available accelerators. 
1. File a new bug on this issue.
2. Take a look at Aarons accessibility doc that lists what keys are already 
being used: http://www.mozilla.org/projects/ui/accessibility/mozkeylist.html 
3. Make a suggestion for an available ccelerator in the new bug.

Comment 9

[Andreas Premstaller]

Oliver: Keyboard shortcut is bug 86161, toolbar item is bug 75927, go and vote
for them if you would like those features implemented. A shortcut is easier to
realize, but first an agreement must be found which key to use.

As for Compact This Folder vs. Compact Folders, I take the discussion over to
bug 93001, which may have some (limited) visibility.

Comment 10

[Navin Gupta]

why are we removing this ? As I pointed out in bug 93001 for local/pop3 folders 
under File menu we have Compact Folders and that does compact all folders under 
that account. The only thing we need to change is when we have selected imap 
folder we need to change it to "Compact This Folder" under File menu. 

Comment 11

[Navin Gupta]

taking

Comment 12

[Andreas Premstaller]

Removing this? Sorry, I don't understand.

for POP and Local: Why is "compact folders" in the menu only active if a folder
is selected? If it compacts all folders, it should also be active if only the
account is selected.  

for IMAP: Yes, that namechange is what this bug was all about in the beginning. 

Comment 13

[Navin Gupta]

This feature was designed to behave just like 4x and it does, (except for imap
part in the ui). Why keep changing stuff without any rhyme or reason ? 
I will change the imap part, though

Comment 14

[Karen Huang]

Refer to bug 64751:
Our client had Compact (All) Folders feature for POP, Local and IMAP "Move to 
Trash" mode and "Delete Immediately" modes.
Our client should change File Menu from "Compact Folders" to "Compact This 
Folder" for IMAP Mark as Deleted mode.

Comment 15

[Karen Huang]

*** Bug 105925 has been marked as a duplicate of this bug. ***

Comment 16

[Karen Huang]

Copying the following comments from bug 105925:


------- Additional Comment #1 From Alex Chaffee 2001-11-14 07:08 -------

The name of the menu item should not be "Compact This Folder" or "Compact
Folders."  It should be "Purge Deleted Messages" or "Purge Messages Marked for
Deletion."  

The meaning of the term "Compact" is far from obvious.  Is it making the folder
smaller on disk?  Is it performing janitorial services on the server?  Plus,
it's plural ("folders"), so I'm not sure if it's going to do things to other
folders (I assume that as implemented, it actually lies and compacts (purges)
just the current folder).

OTOH, If I've just hit "delete" and I'm looking for the menu option that will
*really* delete, I want to see an action term with the word "Deleted" in it, or
at least "Marked for Deletion".  

There is also an option "Empty Trash" that is distracting; in the absence of a
clear "Purge Deleted" function, users (e.g. me) will repeatedly attempt to empty
trash, since that's semantically close to what we really want to do.

In addition, the IMAP standard calls the action "Purge," and MS Outlook calls
the action "Purge Deleted Messages".  Bringing Mozilla in line with the rest of
the universe is not always a bad idea.

Comment 17

[Karen Huang]

I am changing the Severity from trivial to normal since there are many peoples 
confusing about this menu item.....

Comment 18

[jglick]

*** Bug 135367 has been marked as a duplicate of this bug. ***

Comment 19

[Calum Mackay]

I'm confused: I'd like to see functionality that really does compact *all*
folders for IMAP mark as deleted mode; it seems to me that neither bug 94251 nor
bug 93001 directly address this. Should there be a new bug to request this feature?

Comment 20

[Joey Connick]

I believe that new bug you're talking about is bug 164746.  Please vote for it...

Comment 21

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 22

[S. Burmeister]

There is a simple reason as to why this function should be renamed to something
else than compact... If somebody is using POP3 and IMAP he has got one and the
same menu item that does different things, i.e. compressing for POP3 and
deleting for IMAP. Since one can download the message bodies to the hd, in imap
there is certainly an association of compact=compressing. Why make it ambigious,
when it could be simple. Name delete, what deletes, name compress what
compresses, nobody gets confused, nobody harmed as in wanting to save space on
hd but deleting email and the specs, well maybe one should not see them as a
decree but as something open for improvement and clarity. A quick survey with on
the corridor gave a very clear answer as to what compact is associated and it is
not delete.

Comment 23

[Mike Cowperthwaite]

As noted in comment 8:
> File menu item should be "Compact Folders", and it should do just that,
> compact All folders, but currently it does not. :-(   There should be a
> separate bug for that.

And there is, for the IMAP Mark-as-Deleted case: bug 164746.  Therefore, the 
summary on this bug is not actually what is desired.


With the fix in place for bug 142748, File|Compact Folders is now enabled when a 
server is selected, as well as when a folder is.

The menu item is also now enabled for News servers and groups.  David Bienvenu 
told me this was necessary because the code for "compact" actually does 
something for news: it applies the "retention settings" -- that is, it removes 
older headers (per the account settings); and, it is supposed to compact the 
offline store for news messages as well.  ("Compact This Folder" is not 
currently on the newsgroup context menu.)

I agree with comment 16 and comment 22 that the term "Compact" is kind of vague. 
It makes sense for local (and POP) stores, but is less appropriate for the Purge 
case, and I think it may not be appropriate for the News case either, even if an 
offline store is present to be compacted.  I don't have a suggestion for the 
terminology.

Comment 24

[Mike Cowperthwaite]

*** Bug 240923 has been marked as a duplicate of this bug. ***

Comment 25

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008050201 SeaMonkey/2.0a1pre

More than 3½ years since last comment. Resetting A+QA on the assumption that the values set (... @formerly-netcape ...) aren't valid anymore. I wonder what else (if anything) should ber done with this bug.