Closed Bug 942520 Opened 11 years ago Closed 9 years ago

Intermittent browser_sanitizeDialog.js | There is no formdata history, checkbox should be disabled and be cleared to reduce user confusion (bug 497664).

Categories

(Firefox :: Settings UI, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox39 --- wontfix
firefox40 --- fixed
firefox41 --- fixed
firefox-esr31 --- wontfix
firefox-esr38 --- fixed

People

(Reporter: philor, Assigned: ttaubert)

References

(Depends on 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=31013558&tree=Mozilla-Inbound
Ubuntu VM 12.04 mozilla-inbound pgo test mochitest-browser-chrome on 2013-11-23 16:54:12 PST for push dafe29b07bcf
slave: tst-linux32-ec2-084

17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | history visit http://250-minutes-ago.com/ should no longer exist
17:00:11     INFO -  ************************************************************
17:00:11     INFO -  * Call to xpconnect wrapped JSObject produced this error:  *
17:00:11     INFO -  [Exception... "'[object StopIteration]' when calling method: [mozIStorageStatementCallback::handleCompletion]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: no]
17:00:11     INFO -  ************************************************************
17:00:11     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | Console message: [JavaScript Error: "[Exception... "'[object StopIteration]' when calling method: [mozIStorageStatementCallback::handleCompletion]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: no]"]
17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | There is formdata, checkbox to clear formdata should be enabled.
17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | There is history, checkbox to clear history should be enabled.
17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | found checkboxes for preferences
17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | Dialog's OK button should not be disabled
17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | history visit http://10-minutes-ago.com/ should no longer exist
17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | form entry 10-minutes-ago should no longer exist
17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | history pref should be true after accepting dialog with history checkbox checked
17:00:11     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | formdata pref should be true after accepting dialog with formdata checkbox checked
17:00:11  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js | There is no formdata history, checkbox should be disabled and be cleared to reduce user confusion (bug 497664).
17:00:11     INFO -  Stack trace:
17:00:11     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js :: gAllTests</wh.onload :: line 405
17:00:11     INFO -      JS frame :: chrome://mochitests/content/browser/browser/base/content/test/general/browser_sanitizeDialog.js :: WindowHelper.prototype.open/windowObserver/onload/< :: line 831
17:00:11     INFO -      JS frame :: chrome://mochikit/content/browser-test.js :: testScope/test_executeSoon/<.run :: line 734
17:00:11     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Tim, can you please help investigate this top orange? Otherwise, we'll need to disable the test given the frequency with which it's failing.
Flags: needinfo?(ttaubert)
There is no guarantee that the Sanitizer window is fully initialized (i.e. some checkboxes disabled) when the "onload" function is called, but that's what the test assumes.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Flags: needinfo?(ttaubert)
Attachment #8625551 - Flags: review?(mak77)
OS: Linux → All
Hardware: x86 → All
Comment on attachment 8625551 [details] [diff] [review]
0001-Bug-942520-Fix-intermittent-browser_sanitizeDialog.j.patch

Review of attachment 8625551 [details] [diff] [review]:
-----------------------------------------------------------------

This test is really fragile, it uses onload and onunload handlers, they should at least executeSoon...
I'm not a big fan of fixing only one of the subtests, but I see that fixing it properly is a lot of work... Could you please file a (maybe mentored?) bug to rewrite the test with add_task and a load/unload promise helper to make it much more stable
Attachment #8625551 - Flags: review?(mak77) → review+
Depends on: 1177186
https://hg.mozilla.org/mozilla-central/rev/56b6a6eca59a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.