942580 - Duplicate "final sigma" char in Greek keyboard layout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Thanos Lefteris [:alefteris]]

The "final sigma (ς)" character is displayed always in the Greek layout, no matter the caps lock state. The same character is also available as an alt. in "sigma (σ)" character. Apart from the fact that it's two times in the layout without good reason, when in uppercase mode, the alt is displayed as "uppercase sigma (Σ)", the same as the character it's an alternative on and can be confusing.

Tested with images-keon-v1.2-2013-11-23.Gecko-b9f0351.Gaia-5a0802f

Comment 1

[Thanos Lefteris [:alefteris]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13977

Pointer to Github pull-request

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8337390 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13977

Makes sense to me.
Thanks.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/6b4dd7baa58fbba70161d7979d8503f8fb9f64df

Comment 4

[Alfredos-Panagiotis Damkalis [:fredy]]

If it is possible it would be great to land this also at v1-train and v1.2 branches.

What are the steps we have to follow in order to land this fix on those branches?

Thanks

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8337390 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13977

Asking for approval to land this on v1.2, with Bug 942575.

--
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): n/a.
[User impact] if declined: Redundant final sigma key in alternative char menu.
[Testing completed]: Yes, manually.
[Risk to taking this patch] (and alternatives if risky): low, just minor layout adjustment.
[String changes made]: N/A.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Alfredos-Panagiotis Damkalis [:fredy] from comment #4)
> If it is possible it would be great to land this also at v1-train and v1.2
> branches.
> 
> What are the steps we have to follow in order to land this fix on those
> branches?
> 
> Thanks

Just nominate the patch to ask for approval to land this into v1.2.
Please note that it is quite late for v1.2, so not sure if we can really get this patch landed.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Isn't bug 931578 the same bug???

Comment 8

[Thanos Lefteris [:alefteris]]

(In reply to Jan Jongboom [:janjongboom] from comment #7)
> Isn't bug 931578 the same bug???

They are different issues. Bug 931578 was about the separate "final sigma" key being displayed the same way as the "capital sigma" key. This bug is about "final sigma" being an alt option (long press option) in "capital sigma" key and the fact that this alt. option is redundant, so it was removed.

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

Ah, alright, thanks for clearing that up. Last time I read Greek alphabet was in high school :-)

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8337390 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13977

Question: how could people type the final sigma alphabet with this patch applied?

(reset approval to me when the question is answered)

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8337390 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13977

Sorry, I didn't read comment 0 correctly:

> The same character is also available as an alt.

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Uplifted to v1.2 with Tim's approval,
https://github.com/mozilla-b2g/gaia/commit/005a9c0a4e6210cba37b1719c9c21fc3687fbef9

Thanks.