942646 - IAccessibleText::textAtOffset completely broken

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

I can provide proper str if necessary, but I don't feel it is needed. As far as I can determine (and I've poked it pretty thoroughly), IAccessibleText::textAtOffset with any valid offset and boundary, even IA2_TEXT_BOUNDARY_ALL, throws E_INVALIDARG. As you might imagine, this is very problematic. :)

I don't know when exactly this was introduced, but I think it was in the last week or so.

Comment 1

[alexander :surkov (:asurkov)]

if week or so then bug 934039 must be guilty

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

we need to get mindful assignee, careful reviewer and platform automated tests (the latest is necessary if we can't fulfill 1st and 2nd).

Comment 3

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #2)
> Created attachment 8337784 [details] [diff] [review]
> patch
> 
> we need to get mindful assignee, careful reviewer and platform automated
> tests (the latest is necessary if we can't fulfill 1st and 2nd).

there's a reason I really wanted you to break that patch up ;)

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #3)

> > we need to get mindful assignee, careful reviewer and platform automated
> > tests (the latest is necessary if we can't fulfill 1st and 2nd).
> 
> there's a reason I really wanted you to break that patch up ;)

yes, that's right, it will be 4st.

Comment 5

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #4)
> (In reply to Trevor Saunders (:tbsaunde) from comment #3)
> 
> > > we need to get mindful assignee, careful reviewer and platform automated
> > > tests (the latest is necessary if we can't fulfill 1st and 2nd).
> > 
> > there's a reason I really wanted you to break that patch up ;)
> 
> yes, that's right, it will be 4st.

not sure what you mean.

Comment 6

[alexander :surkov (:asurkov)]

I meant it's one more recipe (4th) to avoid those mistakes

Comment 7

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7cda5e479b7c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7cda5e479b7c

Comment 9

[Carsten Book [:Tomcat]]

retriggered nightlies with that changeset included on marco's request

Comment 10

[James Teh [:Jamie]]

Verified fixed in Firefox 28.0a1 (2013-11-26). Thanks!