IAccessibleText::textAtOffset completely broken

VERIFIED FIXED in mozilla28

Status

()

Core
Disability Access APIs
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Jamie, Assigned: surkov)

Tracking

({regression})

Trunk
mozilla28
x86_64
Windows 7
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I can provide proper str if necessary, but I don't feel it is needed. As far as I can determine (and I've poked it pretty thoroughly), IAccessibleText::textAtOffset with any valid offset and boundary, even IA2_TEXT_BOUNDARY_ALL, throws E_INVALIDARG. As you might imagine, this is very problematic. :)

I don't know when exactly this was introduced, but I think it was in the last week or so.
(Assignee)

Comment 1

5 years ago
if week or so then bug 934039 must be guilty
Blocks: 934039
(Assignee)

Comment 2

5 years ago
Created attachment 8337784 [details] [diff] [review]
patch

we need to get mindful assignee, careful reviewer and platform automated tests (the latest is necessary if we can't fulfill 1st and 2nd).
Assignee: nobody → surkov.alexander
Attachment #8337784 - Flags: review?(trev.saunders)
(In reply to alexander :surkov from comment #2)
> Created attachment 8337784 [details] [diff] [review]
> patch
> 
> we need to get mindful assignee, careful reviewer and platform automated
> tests (the latest is necessary if we can't fulfill 1st and 2nd).

there's a reason I really wanted you to break that patch up ;)
Attachment #8337784 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #3)

> > we need to get mindful assignee, careful reviewer and platform automated
> > tests (the latest is necessary if we can't fulfill 1st and 2nd).
> 
> there's a reason I really wanted you to break that patch up ;)

yes, that's right, it will be 4st.
(In reply to alexander :surkov from comment #4)
> (In reply to Trevor Saunders (:tbsaunde) from comment #3)
> 
> > > we need to get mindful assignee, careful reviewer and platform automated
> > > tests (the latest is necessary if we can't fulfill 1st and 2nd).
> > 
> > there's a reason I really wanted you to break that patch up ;)
> 
> yes, that's right, it will be 4st.

not sure what you mean.
(Assignee)

Comment 6

5 years ago
I meant it's one more recipe (4th) to avoid those mistakes
https://hg.mozilla.org/mozilla-central/rev/7cda5e479b7c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
retriggered nightlies with that changeset included on marco's request
(Reporter)

Comment 10

5 years ago
Verified fixed in Firefox 28.0a1 (2013-11-26). Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.