Pressing ESC in a docked scratchpad closes the sidebar but also opens the split console

NEW
Unassigned

Status

P3
normal
5 years ago
3 months ago

People

(Reporter: past, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I noticed this when playing with the App Manager, which meant I was using a remote scratchpad inside the toolbox. Typing window<Cmd-I> opens the variables view sidebar. Now hitting ESC removes the sidebar, but is also displaying the web console in split mode. We should prevent the event propagation in this case.
Brian, is this an easy fix?
(In reply to Panos Astithas [:past] from comment #1)
> Brian, is this an easy fix?

Yes, I've had to do a few of these recently.  If the event is registered on keydown, then a stopPropagation should resolve it.  If it happening on keypress we may need to make the event use capturing instead of bubbling depending on which element the events are bound to.

When trying to test this, for some reason when running scratchpad in the toolbox for app manager, my keyboard shortcuts are not working at all.  Pressing Cmd-I opens up the 'page information' box, and escape is doing nothing.  Maybe this is just something weird in my environment - I take it the shortcuts working for you?
Assignee: nobody → bgrinstead
Panos,
I'm not able to reproduce this with docked scratchpad and when debugging an app in the app manager.  Is there a different way to reproduce?
Flags: needinfo?(past)
Hrmph, trying to reproduce on today's fx-team tip on Linux I can't get either Ctrl-I or ESC to have any effect. I'll try tomorrow on Mac where I first observed the problem and report back.
OK, it looks like keybindings in the App Manager are broken at the moment. Here is another set of steps to reproduce this bug:

- open firefox in one profile and execute 'listen 6666' in gcli
- open firefox in a second profile and use the 'Connect...' menu item to connect remotely to localhost:6666
- select one of the open tabs to debug
- go to the scratchpad tab and type 'window', then hit Cmd-I, then ESC

You should be seeing a split console after the object inspector is dismissed.
Flags: needinfo?(past)
(In reply to Panos Astithas [:past] from comment #5)
> OK, it looks like keybindings in the App Manager are broken at the moment.
> Here is another set of steps to reproduce this bug:
> 
> - open firefox in one profile and execute 'listen 6666' in gcli
> - open firefox in a second profile and use the 'Connect...' menu item to
> connect remotely to localhost:6666
> - select one of the open tabs to debug
> - go to the scratchpad tab and type 'window', then hit Cmd-I, then ESC
> 
> You should be seeing a split console after the object inspector is dismissed.

The behavior seems a bit different now.

Pressing window<cmd+I> opens the variables view, but pressing escape doesn't close it.  I notice this also in a normal scratchpad.
Created attachment 8421060 [details] [diff] [review]
escape-scratchpad-WIP.patch

This prevents split console from opening when esc is pressed in the filter textbox.  It's still an issue if another part of the variables view is focused, and still has the problem where pressing esc in the scratchpad doesn't close the view.
Depends on: 948318
Assignee: bgrinstead → nobody
Scratchpad triage, filter on "ghostbusterzzz"
Priority: -- → P3

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.