942724 - Support multiple notifications for recording device status

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

A content process can support for multiple gUM requests that comes from different origins. We should display recording device status for each origin separately in notification window.

Test case for multiple gUM from different origins. 
http://people.mozilla.org/~schien/gum-test.html

Comment 1

[Jason Smith [:jsmith]]

If I understand this correctly, then this issue being present basically means that requesting gUM audio across different origins in the same content process will not display the fact that the microphone is active on both of those origins, right? Instead, it's likely only showing the latest one in use, right?

We can likely get away with this for 1.2 mainly because this will only happen in the same content process use case, which isn't likely to happen on the web. However, I'm wondering if this needs to be supported for 1.3. We can figure out if it's needed for 1.3 if multiple content process support is allowed for gUM camera.

Comment 2

[Maire Reavy [:mreavy]]

This is either a dependency or a dupe of bug 977971, which was just made blocking 1.4+

Comment 3

[Maire Reavy [:mreavy]]

Ivan -- Is Fred on holiday today?  I assume so.

Fabrice -- Can you help me find an owner (even a temporary owner) today since today is a holiday in Taipei?  (This bug blocks keeping gUM video on in v1.4.)

Comment 4

[[e-mail]]

Current implementation assume single gUM recordings indicator is shown on utility tray. We did not evaluate the risk for both audio/video case.

The task will be managing the recording origins in a list and render multiple recording indicators in the utility tray.


I'm out of my productivity tools until 3/2. I would fix it within sprint 3(before 3/7) if no one take it during the holiday.

Comment 6

[Jason Smith [:jsmith]]

blocking+ - either need to fix this or backout gUM. See the dupe for impact.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #6)
> blocking+ - either need to fix this or backout gUM. See the dupe for impact.

Actually I mean pref off gUM video specifically.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Maire Reavy [:mreavy] from comment #3)
> Ivan -- Is Fred on holiday today?  I assume so.
> 
> Fabrice -- Can you help me find an owner (even a temporary owner) today
> since today is a holiday in Taipei?  (This bug blocks keeping gUM video on
> in v1.4.)

Gregor would probably could backup person to ask. You could ask him if he knows anyone on his team that could take this.

Redirecting the needinfo request to him.

Comment 9

[Gregor Wagner [:gwagner]]

Everyone on my team is already working on 1.3 and 1.4 blockers so we can't get to it by Monday.
I guess I don't have to say that we are pretty late in the game here. This seems to be some basic functionality thats missing and we should find out what went wrong with the dependencies after we fix it.

Comment 10

[Maire Reavy [:mreavy]]

Fred should be back on Monday.  (It's a National Holiday in Taipei today.)  I just talked to Fabrice, and he and I agree that we should be able to get this fixed next week when all of Taipei is back.

Comment 11

[Ivan Tsay (:ITsay)]

(In reply to Maire Reavy [:mreavy] from comment #10)
> Fred should be back on Monday.  (It's a National Holiday in Taipei today.) 
> I just talked to Fabrice, and he and I agree that we should be able to get
> this fixed next week when all of Taipei is back.

I will ask Fred to work on this bug immediately when he is back to Taipei office next Monday.

Comment 12

[Jason Smith [:jsmith]]

I'm actually going to switch to keeping this non-blocking as we won't stop ship for gUM video in 1.4. However, if this isn't fixed in time a few days before merge, then I'll file a separate bug to turn off gUM video on 1.4.

Comment 13

[[e-mail]]

WIP: support multiple messages array in code, will work on the rendering part
https://github.com/mozilla-b2g/gaia/pull/16808

Comment 14

[[e-mail]]

now its workable. will add test cases

Comment 15

[[e-mail]]

Attachment: pull request redirect to github

test with UItests, UItests-privileged, and browser

- use item object to store messages for utility tray.
- track statusbar status
- test cases

travis marionette js fail in `navigation opens rocketbar from homescreen` test case, which is not relevant to this issue

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8385915 [details] [review]
pull request redirect to github

See comments

Comment 17

[[e-mail]]

Comment on attachment 8385915 [details] [review]
pull request redirect to github

Thanks for suggestions. I've update my PR based on your comment in github. Please kindly review again

Comment 18

[[e-mail]]

Comment on attachment 8385915 [details] [review]
pull request redirect to github

will work on the following found issue before flag review

Comment 19

[[e-mail]]

Comment on attachment 8385915 [details] [review]
pull request redirect to github

use camelCase flag, 
kill single panel instead of kill all then repaint

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8385915 [details] [review]
pull request redirect to github

See github.

Comment 21

[[e-mail]]

Comment on attachment 8385915 [details] [review]
pull request redirect to github

update addressed issue and use media_recording to manage statusbar red dot status

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8385915 [details] [review]
pull request redirect to github

r+ if last two comments addressed. Thanks.

Comment 23

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/eb100d861ae424b03f8c2a1051f550e6b9d49734

thanks!