942732 - Device crashes while opening FM in msm devices with iris fm driver

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[vasanth]

Attachment: fm-iris-fix.patch

This is a regression issue caused by fix in bug 852497. 
Only "radio-tavarua" is being checked here[1] but "radio-iris" is used in some device and we need to check that as well. iris is compatible to tavarua however just the driver name is different.

Attached patch fixes this issue and also renaming variables with "tavaura" to msmFM to 
generalize tavarua and iris msm fm drivers.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=832412&action=diff#a/hal/gonk/GonkFMRadio.cpp_sec6

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 8337600 [details] [diff] [review]
fm-iris-fix.patch

Review of attachment 8337600 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

::: hal/gonk/GonkFMRadio.cpp
@@ +275,5 @@
>      return;
>    }
>  
> +  sMsmFMMode = (!strcmp((char *)cap.driver, "radio-tavarua")
> +      || !strcmp((char *)cap.driver, "radio-iris"));

nit: put || at the end of the previous line rather than at the beginning of the line. The additional parenthesis should not be necessary.

Comment 2

[vasanth]

Attachment: fm-iris-fix.patch

Thanks Michael Wu. Addressed Nits.
How do we land this in b2g-inbound?
checkin-needed

Comment 3

[Inder]

Vasanth, please create hg friendly patch.

Comment 4

[vasanth]

Attachment: fm-iris-fix-hg.patch

Adding an hg friendly patch.
New to hg though, let me know if something is wrong.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/904695ed293d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/904695ed293d