Closed Bug 942732 Opened 6 years ago Closed 6 years ago

Device crashes while opening FM in msm devices with iris fm driver

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vasanth, Assigned: vasanth)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch fm-iris-fix.patch (obsolete) — Splinter Review
This is a regression issue caused by fix in bug 852497. 
Only "radio-tavarua" is being checked here[1] but "radio-iris" is used in some device and we need to check that as well. iris is compatible to tavarua however just the driver name is different.

Attached patch fixes this issue and also renaming variables with "tavaura" to msmFM to 
generalize tavarua and iris msm fm drivers.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=832412&action=diff#a/hal/gonk/GonkFMRadio.cpp_sec6
Assignee: nobody → vasanth
Attachment #8337600 - Flags: review?(mwu)
Blocks: 930299
Comment on attachment 8337600 [details] [diff] [review]
fm-iris-fix.patch

Review of attachment 8337600 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

::: hal/gonk/GonkFMRadio.cpp
@@ +275,5 @@
>      return;
>    }
>  
> +  sMsmFMMode = (!strcmp((char *)cap.driver, "radio-tavarua")
> +      || !strcmp((char *)cap.driver, "radio-iris"));

nit: put || at the end of the previous line rather than at the beginning of the line. The additional parenthesis should not be necessary.
Attachment #8337600 - Flags: review?(mwu) → review+
Attached patch fm-iris-fix.patch (obsolete) — Splinter Review
Thanks Michael Wu. Addressed Nits.
How do we land this in b2g-inbound?
checkin-needed
Attachment #8337600 - Attachment is obsolete: true
Keywords: checkin-needed
Vasanth, please create hg friendly patch.
Flags: needinfo?(vasanth)
Keywords: checkin-needed
Depends on: 852497
Adding an hg friendly patch.
New to hg though, let me know if something is wrong.
Attachment #8338338 - Attachment is obsolete: true
Attachment #8338686 - Flags: review?
Flags: needinfo?(vasanth)
Attachment #8338686 - Flags: review? → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/904695ed293d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.