Closed Bug 942803 Opened 6 years ago Closed 6 years ago

key_devToolboxMenuItem should be using key attribute, not keycode attribute

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: Gijs, Assigned: Gijs)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#279

Because now:

> Error finding I: [Exception... "Component returned failure code: 0x80004005
> (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult:
> "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
> resource://gre/modules/ShortcutUtils.jsm :: <TOP_LEVEL> :: line 88"  data:
> no] ShortcutUtils.jsm:90

See also:

https://developer.mozilla.org/en-US/docs/XUL/Attribute/keycode

Because this key also defines a key attribute, maybe we should just remove the keycode attribute entirely?
Attachment #8337701 - Flags: review?(dcamp)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #8337701 - Flags: review?(dcamp) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/59df4f1c7281
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/59df4f1c7281
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.