Closed
Bug 942803
Opened 11 years ago
Closed 11 years ago
key_devToolboxMenuItem should be using key attribute, not keycode attribute
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: Gijs, Assigned: Gijs)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.71 KB,
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#279 Because now: > Error finding I: [Exception... "Component returned failure code: 0x80004005 > (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" nsresult: > "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: > resource://gre/modules/ShortcutUtils.jsm :: <TOP_LEVEL> :: line 88" data: > no] ShortcutUtils.jsm:90 See also: https://developer.mozilla.org/en-US/docs/XUL/Attribute/keycode Because this key also defines a key attribute, maybe we should just remove the keycode attribute entirely?
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8337701 -
Flags: review?(dcamp)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
||
Updated•11 years ago
|
Attachment #8337701 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/59df4f1c7281
Whiteboard: [fixed-in-fx-team]
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/59df4f1c7281
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•