942815 - DevTools themes - webconsole autocomplete hints not visible with new theme

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Brian Grinstead [:bgrins]]

The .jsterm-complete-node is not visible right now because the .jsterm-input-node element has a background color.

Comment 1

[Brian Grinstead [:bgrins]]

Type 'wi' and you don't see the greyed out 'ndow' next to the input as usual.  The popup is still working (if you type just 'w' you will see some options above).

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: webconsole-autocomplete-theme.patch

The .jsterm-complete-node was the white textbox prompting me to originally set the background on .jsterm-input-node, so just set both to transparent, and control their text colors in the specific part for themes at the bottom of the file.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Screenshot 2013-11-25 08.46.22.png

Image of dark theme with colors applied

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Screenshot 2013-11-25 08.46.09.png

Image of light theme with colors applied

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: webconsole-autocomplete-theme.patch

Same as previous patch, but removed commented-out rule.

Comment 6

[Paul Rouget [:paul]]

Comment on attachment 8337744 [details] [diff] [review]
webconsole-autocomplete-theme.patch

ThreeDShadow :( We might want to kill that one day…

Comment 7

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/b3f5ddf086d5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3f5ddf086d5