Closed
Bug 942824
Opened 11 years ago
Closed 11 years ago
Improve wait in test_dialer_make_call
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Assigned: AndreiH)
Details
Attachments
(2 files)
test_dialer_make_call sometimes fails like this.
After the dialer slides into space we need to wait for the outgoing call information to be not u'' before we assert it.
Traceback (most recent call last):
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.adhoc/.env/local/lib/python2.7/site-packages/marionette_client-0.6.2-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.adhoc/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_dialer.py", line 33, in test_dialer_make_call
self.assertEqual(test_phone_number, call_screen.outgoing_calling_contact)
AssertionError: u'+18007072533' != u''
- +18007072533
+
TEST-UNEXPECTED-FAIL | test_dialer.py test_dialer.TestDialer.test_dialer_make_call |
|
Reporter | |
Updated•11 years ago
|
Priority: -- → P1
|
||
Updated•11 years ago
|
Assignee: nobody → viorela.ioia
|
|
||
Comment 1•11 years ago
|
||
Attachment #8337766 -
Flags: review?(zcampbell)
Attachment #8337766 -
Flags: review?(trifandreialin)
Attachment #8337766 -
Flags: review?(florin.strugariu)
Attachment #8337766 -
Flags: review?(andrei.hutusoru)
|
||
Updated•11 years ago
|
Attachment #8337766 -
Flags: review?(florin.strugariu) → review+
|
||
Updated•11 years ago
|
Attachment #8337766 -
Flags: review?(trifandreialin) → review+
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8337766 [details] [review] pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/14021 r+ thanks!
Attachment #8337766 -
Flags: review?(zcampbell)
Attachment #8337766 -
Flags: review?(andrei.hutusoru)
Attachment #8337766 -
Flags: review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Merged to master: https://github.com/mozilla-b2g/gaia/commit/6ed5464af84f3c420b78259dff53f57a6f1be75e Simple patch to v1.2 so marking -> affected.
status-b2g-v1.2:
--- → affected
|
Assignee | |
Updated•11 years ago
|
Assignee: viorela.ioia → andrei.hutusoru
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8338487 -
Flags: review?(bob.silverberg)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8338487 [details] [review] PR https://github.com/mozilla-b2g/gaia/pull/14064 Thanks Andrei!
Attachment #8338487 -
Flags: review?(bob.silverberg) → review+
|
|
||
Comment 6•11 years ago
|
||
Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/b8e4a7106bbc28ed42f04f0642e32654b45551ed
You need to log in
before you can comment on or make changes to this bug.
Description
•