942833 - Compiler warning in jemalloc.c

Status: RESOLVED DUPLICATE of bug 1226907

(Core :: Memory Allocator, defect)

Description

[Denis Dzyubenko [:ddenis]]

Building on a Mac issues the following warning:

/Users/denis/dev/com.comoyo/ffos/mozilla-central/memory/mozjemalloc/jemalloc.c:450:9: warning: '__DECONST' macro redefined
        ^
/usr/include/sys/cdefs.h:276:9: note: previous definition is here
        ^

Comment 1

[Denis Dzyubenko [:ddenis]]

Attachment: No bug - Fixed compiler warning in jemalloc.c on Mac

Comment 2

[(Away)]

(In reply to Denis Dzyubenko [:ddenis] from comment #1)
> Created attachment 8337749 [details] [diff] [review]
> No bug - Fixed compiler warning in jemalloc.c on Mac

Does this really fix the warning? It seems like the warning is about the unconditional #define at line 450: https://hg.mozilla.org/mozilla-central/file/9ac7ed427cd2/memory/mozjemalloc/jemalloc.c#l450

Comment 3

[Denis Dzyubenko [:ddenis]]

You are absolutely right. I missed that __DECONST is not something jemalloc specific but also declared in /usr/include/sys/cdefs.h

Comment 4

[Denis Dzyubenko [:ddenis]]

Attachment: Fixed compiler warning in jemalloc.c on Mac

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8342345 [details] [diff] [review]
Fixed compiler warning in jemalloc.c on Mac

Review of attachment 8342345 [details] [diff] [review]:
-----------------------------------------------------------------

Protect it with ifndef, but don't remove it.

Comment 6

[Denis Dzyubenko [:ddenis]]

My patch removes the second definition of the macro - there are two of them in the same file.

Here is the first one: http://dxr.mozilla.org/mozilla-central/source/memory/mozjemalloc/jemalloc.c#315
There is the second one that the attached patch removes: http://dxr.mozilla.org/mozilla-central/source/memory/mozjemalloc/jemalloc.c#450

Comment 7

[Mike Hommey [:glandium]]

The first one is in a ifndef MOZ_MEMORY_WINDOWS. The second isn't.

Comment 8

[Denis Dzyubenko [:ddenis]]

Attachment: Fixed compiler warning in jemalloc.c on Mac

Indeed you are right.
/me puts his brown bag on.

Comment 9

[jbonnafo]

Hello,

What is needing in order to help this patch proposal landing ?

Thanks,

Comment 10

[Mike Hommey [:glandium]]

This was fixed in bug 1226907.