942865 - [Settings][WiFi] In wifi settings, 'Show Password' checkbox makes the keyboard disappear

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

A common scenario is the following:

The user introduces part of the password while the textbox is masked, but at some point wants to check that the password introduced is correct so far. Tapping 'Show password' will make the keyboard hide because it steals the textbox focus. That is almost never what the user wants to happen, besides the fact that in that particular screen the area filled by the keyboard is already empty.

The solution to this would be to set '-moz-user-focus: ignore', but unfortunately this is not working at the moment for touch events (https://bugzilla.mozilla.org/show_bug.cgi?id=894383).

Other workarounds like setting `tabIndex` to -1 or preventing default behavior on the element don't work either.

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: GitHub PR

This patch fixes the issue with a proper solution using -moz-user-focus: ignore, but since there is another bug related to focus and touch events (894383), this patch also includes a solution which refocus the cursor in the textfield whenever the user changes the checkbox.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8338500 [details] [diff] [review]
GitHub PR

Evelyn, could you help review this patch?

Comment 3

[Evelyn Hung]

Comment on attachment 8338500 [details] [diff] [review]
GitHub PR

Hi sergi, 
Thanks for giving this patch. It works fine but I think we don't need the workaround of bug 894383, or we need a follow-up bug to remove it when bug 894383 is getting fixed. I feel like only CSS change here is simpler, and we can highlight their dependency when closing this issue as fixed. What do you think?

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi Evelyn,

Sounds good, I've updated the patch accordingly and will merge now.

Cheers

Comment 5

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This bug will be effectively fixed as soon as Bug 894383 is resolved.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This is still an issue, so reopening (regardless of code that's checked in, the issue isn't fixed -- even if the root cause is an underlying problem).

Comment 7

[Oliver Nelson [:oliverthor]]

This issue still occurs on 3.0 for flame devices.
Results: Tapping show password will drop focus from the textbox in order to reveal, though probable that it's against user's password entry scenario.

--------------------------------------------------
Environmental Variables:
Device: Flame 3.0
BuildID: 20150306010207
Gaia: 7a91c16bfa348be8b25e09719178efa051512988
Gecko: 0189941a3fd5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0
--------------------------------------------------

Comment 9

[Kevin Grandon :kgrandon]

Currently the keyboard doesn't disappear, but the focus is incorrect. That's being tracked in bug 1218717.