942907 - asterisk * sign for favorites wraps into main space with long contact names

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Zac C (:zac)]

Attachment: 2013-11-25-17-16-55.png

STR
1. Create a contact with a long first and family name
2. go into Contact details
3. Tap "add as favourite"
4. Star will wrap onto second line as per screenshot

Build:
Gecko  http://hg.mozilla.org/mozilla-central/rev/250bb14d76d4
Gaia  9935ceb4fe96fff48e78b941cfd2a69d8639a418
BuildID 20131125040208
Version 28.0a1

Regression range unknown sorry (this is not from automation)

Comment 1

[Jason Smith [:jsmith]]

Can someone check if this reproduces on 1.2 or 1.1?

Comment 2

[Sarah Parsons]

This issue reproduces on Buri 1.2 Build ID: 20131125004001 and does NOT reproduce on Leo 1.1 Build ID: 20131122041201.

-1.2 Regression Window-

This issue started to occur on the Buri 1.2 Build ID: 20131002004001

Gaia   def8e152db6a317162c03a316f68c409f3af3979
SourceStamp b955a00f4167
BuildID 20131002004001
Version 26.0a2

Last working Buri 1.2 Build ID: 20131001004003

Gaia   5e0d0df6a762cf1e1812eeb735fba72e2539dc0c
SourceStamp 5689e4237ab7
BuildID 20131001004003
Version 26.0a2

Comment 3

[Jason Smith [:jsmith]]

Probably isn't going to block as it's a visual glitch, but we should look into this.

Comment 4

[Jose Manuel Cantera]

I can confirm this also reproduces at least on v1.2. It is not a regression. However I would like to see it fixed on v1.3 at least, as it is a visual issue that affects the perceived quality of the product, IMHO.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8346808 [details]
patch in github

works perfectly but we need to update the unit and integration tests. Please could you add the following patch to your PR ?

https://github.com/jmcanterafonseca/gaia/commit/d8c51212c05786096acb9da1723408aca0a0a035.patch

Then, please 

A/ ask for a review for the integration tests to Kevin Grandon, as I'm not confident with the Marionette stuff. 
B/ Check the Travis results to be green :)

thanks!

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Thanks Jose Manuel :)

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8346808 [details]
patch in github

Kevin, could you please review this patch? 
To fix this bug I have removed an unneeded tag, which appears in an integration test.
Thanks!

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8346808 [details]
patch in github

(In reply to Arnau March from comment #8)
> Comment on attachment 8346808 [details]
> patch in github
> 
> Kevin, could you please review this patch? 

Not a peer, so forwarding to a peer for review. Jose, Francisco - could one of you review this? Thanks!

Comment 10

[Jose Manuel Cantera]

Comment on attachment 8346808 [details]
patch in github

Hi Kevin,

I've already reviewed this patch, however I want you to review the changes in the marinonette-JS tests, as it is the first time I touch there and I think you are experienced on that. 

Sorry for the misunderstanding

thanks

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8346808 [details]
patch in github

Ah, sorry about that! The code looks fine to me, but I did not run it locally. Please just ensure that travis turns green before landing. Thanks!

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Travis green ;)

Merged: e2e7add56f545f2086ab15525ba20b111e5e386f

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

triage: !.3+

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e2e7add56f545f2086ab15525ba20b111e5e386f to:
v1.3: e40a5ef5208807cb7f18550b61b0b00f1aa83063