942921 - dom/base/nsGlobalWindow.cpp:1157:26: error: 'getpid' was not declared in this scope

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Beich]

Attachment: Explicitly include unistd.h for getpid() for non-Linux debug builds.

Probably, broken on any XP_UNIX that is not XP_LINUX.

dom/base/nsGlobalWindow.cpp:1157:19: error:
      use of undeclared identifier 'getpid'
                  getpid(),
                  ^
dom/base/nsGlobalWindow.cpp:1235:19: error:
      use of undeclared identifier 'getpid'
                  getpid(),
                  ^
2 errors generated.
docshell/base/nsDocShell.cpp:809:21: error:
      use of undeclared identifier 'getpid'
                    getpid(),
                    ^
docshell/base/nsDocShell.cpp:841:23: error:
      use of undeclared identifier 'getpid'
                      getpid(),
                      ^
2 errors generated.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8337837 [details] [diff] [review]
Explicitly include unistd.h for getpid() for non-Linux debug builds.

Review of attachment 8337837 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but I can't technically give you r+.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb9997a79224

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb9997a79224