dom/base/nsGlobalWindow.cpp:1157:26: error: 'getpid' was not declared in this scope

RESOLVED FIXED in mozilla28

Status

()

Product:
Core
Component:
DOM
Status:
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: jbeich, Assigned: jbeich)

Tracking

Version:
Trunk
Target:
mozilla28
Platform:
x86_64
FreeBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Explicitly include unistd.h for getpid() for non-Linux debug builds.
1.33 KB, patch
smaug
: review+
ttaubert
: feedback+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
Created attachment 8337837 [details] [diff] [review]
Explicitly include unistd.h for getpid() for non-Linux debug builds.

Probably, broken on any XP_UNIX that is not XP_LINUX.

dom/base/nsGlobalWindow.cpp:1157:19: error:
      use of undeclared identifier 'getpid'
                  getpid(),
                  ^
dom/base/nsGlobalWindow.cpp:1235:19: error:
      use of undeclared identifier 'getpid'
                  getpid(),
                  ^
2 errors generated.
docshell/base/nsDocShell.cpp:809:21: error:
      use of undeclared identifier 'getpid'
                    getpid(),
                    ^
docshell/base/nsDocShell.cpp:841:23: error:
      use of undeclared identifier 'getpid'
                      getpid(),
                      ^
2 errors generated.
Attachment #8337837 - Flags: review?(ttaubert)

Comment 1

•
5 years ago 
Comment on attachment 8337837 [details] [diff] [review]
Explicitly include unistd.h for getpid() for non-Linux debug builds.

Review of attachment 8337837 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but I can't technically give you r+.
Attachment #8337837 - Flags: review?(ttaubert)
Attachment #8337837 - Flags: review?(bugs)
Attachment #8337837 - Flags: feedback+
 (Assignee)

Updated

•
5 years ago
Attachment #8337837 - Attachment description: include fix → Explicitly include unistd.h for getpid() for non-Linux debug builds.

Updated

•
5 years ago
Attachment #8337837 - Flags: review?(bugs) → review+
 (Assignee)

Updated

•
5 years ago
Keywords: checkin-needed

Comment 2

•
5 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb9997a79224
Assignee: nobody → jbeich
Keywords: checkin-needed

Comment 3

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/eb9997a79224
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.