Closed Bug 942921 Opened 7 years ago Closed 7 years ago

dom/base/nsGlobalWindow.cpp:1157:26: error: 'getpid' was not declared in this scope

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
FreeBSD
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

Explicitly include unistd.h for getpid() for non-Linux debug builds.
1.33 KB, patch
smaug
: review+
ttaubert
: feedback+
Details | Diff | Splinter Review 
Probably, broken on any XP_UNIX that is not XP_LINUX.

dom/base/nsGlobalWindow.cpp:1157:19: error:
      use of undeclared identifier 'getpid'
                  getpid(),
                  ^
dom/base/nsGlobalWindow.cpp:1235:19: error:
      use of undeclared identifier 'getpid'
                  getpid(),
                  ^
2 errors generated.
docshell/base/nsDocShell.cpp:809:21: error:
      use of undeclared identifier 'getpid'
                    getpid(),
                    ^
docshell/base/nsDocShell.cpp:841:23: error:
      use of undeclared identifier 'getpid'
                      getpid(),
                      ^
2 errors generated.
Attachment #8337837 - Flags: review?(ttaubert)
Comment on attachment 8337837 [details] [diff] [review]
Explicitly include unistd.h for getpid() for non-Linux debug builds.

Review of attachment 8337837 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but I can't technically give you r+.
Attachment #8337837 - Flags: review?(ttaubert)
Attachment #8337837 - Flags: review?(bugs)
Attachment #8337837 - Flags: feedback+
Attachment #8337837 - Attachment description: include fix → Explicitly include unistd.h for getpid() for non-Linux debug builds.
Attachment #8337837 - Flags: review?(bugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eb9997a79224
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.