942946 - ESC closes Responsive Design Mode while opening Web Console split view

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Merih Akar]

Steps to reproduce:
1) Enable "Responsive Design Mode"
2) Open "Developer Tools"
3) Select any tab other than "Console"
4) Press ESC to split the view to see both selected tab content and web console

What happened:
Responsive Design Mode is closed while Web Console split view is toggled.

What should happen:
There should be a way to toggle Web Console while keeping Responsive Design Mode enabled.

ESC key doing two thing at the same time is confusing and re-enabling Responsive Design Mode whenever Web Console is toggled is bothersome. Not closing the Responsive Design Mode while the focus is on Developer Tools, or changing the shortcut key for toggling Web Console split view are possible options.

Comment 1

[Brian Grinstead [:bgrins]]

Yes, the shortcut for closing responsive design mode should stopPropagation on the escape key event, so that the split console does not get toggled.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: responsive-esacpe.patch

Prevents escape from toggling split console when responsive design mode is on by using capturing on the event.  Also updates the text color in the resolution dropdown to match dark theme (on OSX, at least, it is currently black text on dark grey background).

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e45be9ec0e4e.

Comment 3

[Merih Akar]

So after this patch lands, there will be no single step method to toggle split console? I mean, will the only way to open split console be first closing the responsive design mode, then opening split console, and finally enabling responsive design mode again?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to merihakar from comment #3)
> So after this patch lands, there will be no single step method to toggle
> split console? I mean, will the only way to open split console be first
> closing the responsive design mode, then opening split console, and finally
> enabling responsive design mode again?

Correct - if responsive design more is opened, then first escape will close responsive design.  A second escape would toggle the split console.  Keep an eye on Bug 938616, in which we will be adding a button for toggling the split console.

Comment 5

[Merih Akar]

Thanks for explanation. I will keep an on the issue you mentioned.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/ad0b0ca62e46

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ad0b0ca62e46

Comment 8

[Paul Rouget [:paul]]

regression: bug 945697

Comment 9

[Ada [:adalucinet]]

Reproduced with Nightly from 2013-11-25.
Verified as fixed with latest Aurora (Build ID: 20140131004003) with STR from comment 0: Responsive design mode is closed at the first ESC press and with a second attempt, the Web Console split view is opened; It also works as expected with the Toggle split console button.

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (X11; Linux i686; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:28.0) Gecko/20100101 Firefox/28.0