maybeSetFrameIsCritical is unused after activity window refactor

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c= p=1 s= u=])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Originally implemented: https://github.com/mozilla-b2g/gaia/commit/21390f7a442a98d7bea8599cf52e180d0d1feb02

Removed in: https://github.com/mozilla-b2g/gaia/commit/d69c210e1502b269835e1333f676e5b5c29283eb#diff-fd6daebc0fb827952f791e6ace77107a

We either need to restore this, or remove it if unneeded.
(Assignee)

Comment 1

4 years ago
Alive - do you think we need to set the mozapptype='critical' attribute somewhere?

Seems this would also be a good candidate for an integration test.
Flags: needinfo?(alive)
Kevin - thanks for point out. The whole Window Manager is going to be removed in bug 907013.
PR is https://github.com/mozilla-b2g/gaia/pull/13797
Also maybeSetFrameIsCritical now is living in browser_frame.js.

I'm curious about how could integration test interact with OOM test?
Depends on: 907013
Flags: needinfo?(alive)
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/browser_frame.js#L82(In reply to Alive Kuo [:alive][NEEDINFO] from comment #2)
> Also maybeSetFrameIsCritical now is living in browser_frame.js.
(Assignee)

Comment 4

4 years ago
Created attachment 8338191 [details] [review]
Github pull request - remove unused code

Hi Alive - I see that the functionality now in browser_frame. I think we should remove the unused code for now.
Attachment #8338191 - Flags: review?(alive)
Attachment #8338191 - Flags: review?(alive) → review+
(Assignee)

Comment 5

4 years ago
Thanks for the review!

Landed in master: https://github.com/mozilla-b2g/gaia/commit/5cc474a1d40cf7dbccc7d7933fef7611cc8dbadb
Assignee: nobody → kgrandon
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: perf
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Resolution: --- → FIXED
Whiteboard: [c= p=1 s= u=]
You need to log in before you can comment on or make changes to this bug.