942955 - maybeSetFrameIsCritical is unused after activity window refactor

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

Originally implemented: https://github.com/mozilla-b2g/gaia/commit/21390f7a442a98d7bea8599cf52e180d0d1feb02

Removed in: https://github.com/mozilla-b2g/gaia/commit/d69c210e1502b269835e1333f676e5b5c29283eb#diff-fd6daebc0fb827952f791e6ace77107a

We either need to restore this, or remove it if unneeded.

Comment 1

[Kevin Grandon :kgrandon]

Alive - do you think we need to set the mozapptype='critical' attribute somewhere?

Seems this would also be a good candidate for an integration test.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Kevin - thanks for point out. The whole Window Manager is going to be removed in bug 907013.
PR is https://github.com/mozilla-b2g/gaia/pull/13797
Also maybeSetFrameIsCritical now is living in browser_frame.js.

I'm curious about how could integration test interact with OOM test?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/browser_frame.js#L82(In reply to Alive Kuo [:alive][NEEDINFO] from comment #2)
> Also maybeSetFrameIsCritical now is living in browser_frame.js.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request - remove unused code

Hi Alive - I see that the functionality now in browser_frame. I think we should remove the unused code for now.

Comment 5

[Kevin Grandon :kgrandon]

Thanks for the review!

Landed in master: https://github.com/mozilla-b2g/gaia/commit/5cc474a1d40cf7dbccc7d7933fef7611cc8dbadb