942973 - [System][Notifications] 1.3 Visual Refresh of Notification Icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Amy Lee [:amylee] UX]

Attachment: Notification_Tray_Icons_v1.3.zip

Hi, 

Attached are updated notification tray icons for v1.3. Please replace the existing ones in the build. 

Thanks!

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Eric,
can you help me with the following icons?

- [e-mail]
- [e-mail]

I'm not sure where we use them

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Hey Eric,
> can you help me with the following icons?
> 
> - [e-mail]
> - [e-mail]
> 
> I'm not sure where we use them

These might be notifications that are currently not used.  Might make sense to copy them onto gaia so that the images are there if the functionality becomes available in the future.  Amy do you know if they are currently being used?

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I think that it's not a good idea to have unused images somewhere

Comment 5

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #4)
> I think that it's not a good idea to have unused images somewhere

Yes I agree :) 
Is this patch ready for testing?  If so can you flag Amy for feedback? Thanks!

Comment 6

[Amy Lee [:amylee] UX]

Hi Pavel, 

These look good to me. Thanks!

Comment 7

[Eric Pang [:epang] UX]

Comment on attachment 8337953 [details] [review]
patch for Gaia/master

I looked at this already in the morning.  Looks good, let's land!

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/47c7c56e9dba7600fdf11b2adb822e77b9145c91