942991 - [AccessFu] Update virtual cursor navigation sounds.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Andre Louis is kindly helping us with mastering new sound effects for our Firefox OS screen reader.

This bug is for updating our virtual cursor changed sound. There will be one kind of sound for regular objects, and another for keys. This is to distinguish objects that are activated by double tap, and objects that are activated by lifting the finger.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Updated virtual cursor navigation sounds.

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 8337932 [details] [diff] [review]
Updated virtual cursor navigation sounds.

The sounds are great, however there is a logic in the way the key entering sound is handled. The keyboard specific sound should be heard when the key is entered, not when it is navigated to. The difference should be in the sounds that are heard when activating items vs. entering keys. Right now, as this and the patch for bug 942994 play together, no feedback at all is heard when a key is actually entered.

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Marco Zehe (:MarcoZ) from comment #2)
> Comment on attachment 8337932 [details] [diff] [review]
> Updated virtual cursor navigation sounds.
> 
> The sounds are great, however there is a logic in the way the key entering
> sound is handled. The keyboard specific sound should be heard when the key
> is entered, not when it is navigated to. The difference should be in the
> sounds that are heard when activating items vs. entering keys. Right now, as
> this and the patch for bug 942994 play together, no feedback at all is heard
> when a key is actually entered.

The logic here is that there needs to be an indication that the user is on another type of object, that will behave differently. The Gaia keyboard has its own click sounds that are turned off by default. In any case, most keys would already have some sort of sound, like the DTMF tones in the dialer keypad.

My proposal is this: Along with this patch, we should also open a bug in the keyboard Gaia app for click sounds when the screen reader is enabled.

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 8337932 [details] [diff] [review]
Updated virtual cursor navigation sounds.

OK, changing to an r+, then. And yes, I think we should give *some* indication that something happens. I mean, at some point we'll want to have keyboard echo, but at least we should be giving feedback now that the entry was successful. Before these two patches, unless you were entering a shifted character, it would at least announce "clicked".

And we should definitely soon take care of bug 920946.

Comment 5

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f0cc26c7baf

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3f0cc26c7baf