Created attachment 8337954 [details] Video.png Update to the dark 1.3 header in the select screen of the video app.
cyee said I could take this :)
(In reply to Joshua Smith [:joshua-s] from comment #1) > cyee said I could take this :) Great, thanks Joshua! Flag me for feedback when ready :)
Created attachment 8339289 [details] [review] PR on Github
Hey Joshua, this is looking really close. Thanks! But is there a reason why the text is far from the left? I believe there should be a 30px margin from the left. Casey, is this an issue with the building block?
The issue is caused by https://github.com/mozilla-b2g/gaia/blob/master/shared/style/headers.css#L24. If you want me to include a fix with my pull, I can.
Oh, stupid me! I meant https://github.com/mozilla-b2g/gaia/blob/master/apps/video/style/video.css#L322.
Should be ready, unless you want me to remove this (https://github.com/Joshua-S/gaia/blob/ae0463c569163efe21c2ebc077671a8d5470434a/apps/video/style/video.css#L315-L318) as well.
(In reply to Joshua Smith [:joshua-s] from comment #8) > Created attachment 8339466 [details] > Screenshot after the patch this looks good, just needs the adjustment with the header font weight (to light)
This patch looks good to me. r+
merged to master f2562a7