943006 - Update Shumway to version 0.7.806

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Yury Delendik (:yury)]

Changelog:


#995 Filter optimizations and bugfixes
#994 Refactoring and setting to force HiDPI
#992 Fixing async file loading
#991 Refactoring extension code to preserve URL and principal
#987 Update Makefile
#985 Attempts to snap scaled often-used images
#984 Lows dpi for the SWF 17 and below
#983 Optimize and cleanup DisplayObject
#981 Re-enable 3_joystick test
#979 Speed up reftests
#978 Super
#977 Buttons to Disable Phases
#976 Fixes for vertical space issues in TextField
#974 Fixes regression in #968
#973 Display list updating optimizations
#969 Cache graphics bounds instead of iterating over all contained paths over and over again
#968 Misc timeline fixes
#967 Fixes and optimizations for bounds calculation
#963 Add more detailed timeline info.
#962 Fix linter errors in resourceloader.js
#961 Fixes regression in #944
#960 Some resourceloader cleanup
#958 Misc fixes
#957 Tools
#956 Coerce to trait type when setting properties.
#954 Overrides.
#953 Extract parsing functionality out of Loader.js into swf/resourceloader.js
#952 Fixes timeline updates
#950 Filter experiments
#949 Fix removeChildren
#948 Add root to stage before running its constructor.
#947 More display fixes
#944 Misc display fixes
#942 Caches often used bitmapdata
#937 Small Inspector fixes
#935 Accepting postMessage to control keys/mouse events
#933 Fixes #932 (Mask does not work for some movies)
#931 Blacklist Vimeo
#928 Variety Pack
#927 Add another URL for soundcloud player to the blacklist
#925 Prevent Soundcloud's player from breaking
#924 Stubs couple of methods for #920
#922 Stub out classes required to get MIT Scratch SWFs running to the main interface
#918 Correctly handle drawing groups within an embedded shape
#916 Implement AS2's TextFormat#getTextExtent
#914 Implement AS2 TextField.variable accessor
#911 Bugfixes in AS2Utils
#910 Fixes for #471
#905 Misc fixes for spilgames
#896 Fixes regression from 299f5b2b770648
#892 Fixes stage alignment
#891 Fixes display list updates when looping
#890 Delays mousedown/mouseup after mousemove
#884 Fixed regression that causes all avm2 tests to fail in the js shell
#883 Misc avm1 fixes
#882 Reduce spew from parser and builder
#881 Transfer ShapePath commands and (morph) data from worker to main thread instead of copying
#880 Added Tabzilla To Top Of The Page.
#877 Shape code cleanup and optimization
#875 Replacing format for non-html text
#872 Misc fixes for flixel Mode
#865 Fixes transparent BitmapAssets
#864 Misc fixed for jwplayer
#862 Gracefully handle some invalidity in morph shapes
#861 Misc Fixes.
#858 Fixes bitmap pattern color transform
#856 Misc fixes for vimeo
#854 Delays profiler initialization
#852 Misc fixes for spilgames
#847 Merge swf/util.js into flash/util.js and update all references

Comment 1

[Yury Delendik (:yury)]

Attachment: Update Shumway to version 0.7.798

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8337964 [details] [diff] [review]
Update Shumway to version 0.7.798

Review of attachment 8337964 [details] [diff] [review]:
-----------------------------------------------------------------

I only looked through the browser-integration parts, for obvious reasons.

Btw, you don't need/should add the previous import bugs as blocking this one: they really don't block it, after all, they're just earlier instances of the same task.

::: browser/extensions/shumway/content/ShumwayStreamConverter.jsm
@@ +73,5 @@
>  
>  function getDOMWindow(aChannel) {
> +  var requestor = aChannel.notificationCallbacks ?
> +                  aChannel.notificationCallbacks :
> +                  aChannel.loadGroup.notificationCallbacks;

Can be simplified to just `aChannel.notificationCallbacks || aChannel.loadGroup.notificationCallbacks`

@@ +792,5 @@
>        }
>      }
>  
> +    if (!url) {
> +      throw new Error('Movie url is not specified');

What does the Flash plugin do in such a case? I doubt just throwing an exception is the right thing to do.

Comment 3

[Yury Delendik (:yury)]

Attachment: Update Shumway to version 0.7.806

Additional pull requests included:

#999 Addresses bug 943006 comment 2 review
#998 Misc fixes for media support
#996 Fixes invalidation

Comment 4

[Yury Delendik (:yury)]

(In reply to Till Schneidereit [:till] from comment #2)
> Comment on attachment 8337964 [details] [diff] [review]
> Update Shumway to version 0.7.798
> 
> Review of attachment 8337964 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I only looked through the browser-integration parts, for obvious reasons.
> 
> Btw, you don't need/should add the previous import bugs as blocking this
> one: they really don't block it, after all, they're just earlier instances
> of the same task.

Just following the steps of pdf.js intergration with m-c process.

> 
> ::: browser/extensions/shumway/content/ShumwayStreamConverter.jsm
> @@ +73,5 @@
> >  
> >  function getDOMWindow(aChannel) {
> > +  var requestor = aChannel.notificationCallbacks ?
> > +                  aChannel.notificationCallbacks :
> > +                  aChannel.loadGroup.notificationCallbacks;
> 
> Can be simplified to just `aChannel.notificationCallbacks ||
> aChannel.loadGroup.notificationCallbacks`

Fixed by PR 999 above

> 
> @@ +792,5 @@
> >        }
> >      }
> >  
> > +    if (!url) {
> > +      throw new Error('Movie url is not specified');
> 
> What does the Flash plugin do in such a case? I doubt just throwing an
> exception is the right thing to do.

Added comment: it is more an assert. Normally you shall have the url populated here.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/e983514f1f26

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e983514f1f26