943020 - Operator shelves are not showing up

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Switch from Telenor Hungary SIM to a DT Poland SIM
2. Restart phone
3. Launch marketplace-dev app
4. Switch to seeing content for Poland when prompted
5. Click on categories to find the operator shelf

expected behavior:
Operator shelf for DT is listed among the categories

observed behavior:
Operator shelf for DT is missing

ID:fc39d

Comment 1

[krupa raj[:krupa]]

Attachment: missing op shelf from categories list

Comment 2

[krupa raj[:krupa]]

Same case with my movistar SIM

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Please supply MCC/MNC pairs and/or logs.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

We are not supposed to list empty operator shelves. Telenor Hungary is empty hence no operator shelf link:
https://marketplace-dev.allizom.org/?mcc=216&mnc=1
https://marketplace-dev.allizom.org/curation/collection/telenor-hu

DT Poland has apps hence an operator shelf link:
https://marketplace-dev.allizom.org/?mcc=260&mnc=02
https://marketplace-dev.allizom.org/curation/collection/dt-pl
http://f.cl.ly/items/2F140r3a0M0D3a3S342i/Screen%20Shot%202013-11-25%20at%207.33.06%20PM.png

I don't see any problems here.

Comment 5

[krupa raj[:krupa]]

ID:787da this is for MOvistar SIM. Categories doesn't list the op shelf

Comment 6

[krupa raj[:krupa]]

Attachment: screenshot for Spain

Comment 7

[Matt Basta [:basta]]

Krupa: with the logs you sent, I'm seeing the operator shelf in the API responses and when I run the marketplace with that MCC/MNC I see an operator shelf in the list. In fact, I'm seeing the log item to insert the shelf into the dropdown:

[homepage] Injecting operator shelf into cat dropdown

I made a speculative fix:

https://github.com/mozilla/fireplace/commit/3a03ec0746ddcb00f48ad6cea7b540fc9f76ffb8

Comment 8

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/41ac87c