Closed Bug 943035 Opened 8 years ago Closed 8 years ago

nsScriptableInputStream::Read should use fallible allocator

Categories

(Core :: XPCOM, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: benjamin, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

https://crash-stats.mozilla.com/report/index/17e78984-2d29-4f66-be05-7d5362131122

One of the common causes of OOM aborts appears to be the use of the infallible allocator in nsScriptableInputStream::Read. This should use a fallible allocator at http://hg.mozilla.org/releases/mozilla-release/annotate/d86ad7db1de3/xpcom/io/nsScriptableInputStream.cpp#l45
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #8338462 - Flags: review?(benjamin)
Attachment #8338462 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/abb41f4fdc5d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.