Closed Bug 943070 Opened 6 years ago Closed 6 years ago

Add a "depth" trace type to the tracer

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 1 obsolete file)

The tracer should be able to give us frame depth, so we don't need to reconstruct it on the client.
Argh, actually this is failing and my test is bad. Turns out that Debugger.Frame#depth is not implemented which makes me very sad :(
Attachment #8338060 - Flags: review?(past)
...and fixes the test of course.
Comment on attachment 8338124 [details] [diff] [review]
bug-943070-depth-trace-type.patch

Review of attachment 8338124 [details] [diff] [review]:
-----------------------------------------------------------------

OK!
Attachment #8338124 - Flags: review?(past) → review+
https://hg.mozilla.org/mozilla-central/rev/012395358640
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.