Closed
Bug 943070
Opened 11 years ago
Closed 11 years ago
Add a "depth" trace type to the tracer
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.20 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
The tracer should be able to give us frame depth, so we don't need to reconstruct it on the client.
|
Assignee | |
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=236c8bf6374d
Attachment #8338060 -
Flags: review?(past)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Argh, actually this is failing and my test is bad. Turns out that Debugger.Frame#depth is not implemented which makes me very sad :(
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8338060 -
Flags: review?(past)
|
|
Assignee | |
Comment 3•11 years ago
|
||
This patch polyfills bug 943125. https://tbpl.mozilla.org/?tree=Try&rev=13f68968345c
Attachment #8338060 -
Attachment is obsolete: true
Attachment #8338124 -
Flags: review?(past)
|
|
Assignee | |
Comment 4•11 years ago
|
||
...and fixes the test of course.
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8338124 [details] [diff] [review] bug-943070-depth-trace-type.patch Review of attachment 8338124 [details] [diff] [review]: ----------------------------------------------------------------- OK!
Attachment #8338124 -
Flags: review?(past) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/012395358640
Whiteboard: [fixed-in-fx-team]
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/012395358640
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•