943086 - Keep Scrolling Portion of Calendar App as One Layer using will-animate

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[Mason Chang [Inactive] [:mchang]]

Append the css property will-animate: scroll to the scrollable portion of the calendar app.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Github Pull Request

I guess the proper way to review for Gaia is to attach github pull requests to bugs.

Comment 2

[Benoit Girard (:BenWa)]

Video looks good. On my device the calendar was smooth even before this. Did you see a performance improvement?

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8341291 [details] [review]
Github Pull Request

r+, even if we don't skip frames this should be easier on the battery.

Comment 4

[Mason Chang [Inactive] [:mchang]]

The performance already seemed pretty spiffy, I didn't check the rasterize times in a profile. I'll do that.

Comment 5

[Mason Chang [Inactive] [:mchang]]

Landed - https://github.com/mozilla-b2g/gaia/pull/14284

Comment 6

[Mason Chang [Inactive] [:mchang]]

Here are some profiling results with will-animate for the calendar app. Each number represents the 'rasterize' time in milliseconds of the first 5 frames of the compositor.

With:
http://people.mozilla.org/~bgirard/cleopatra/#report=3f52c3a1f612969f0ab716e7b409aaad373fcfc0
2.30
9.92
9.38
8.39
36.94
Total: 66.93

Without:
http://people.mozilla.org/~bgirard/cleopatra/#report=d7c78b2e57cb4bc34ccbb1448a00d7343e7158db
74.94
8.31
7.58
5.73
4.81
Total: 101.37

In total, looks like we save ~34 ms.