943121 - geolocation example might have rotted

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P1)

Description

[Will Bamberg [:wbamberg]]

See http://stackoverflow.com/questions/20137657/mdn-add-on-sdk-geolocation-error-xpcwrappednative-nohelper-ns-error-xpc-bad.

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: updated tutorial page on MDN

tested the code from SO and updated the tutorial page on MDN.

Comment 2

[Will Bamberg [:wbamberg]]

Comment on attachment 8384200 [details]
updated tutorial page on MDN

Thanks for picking this up! I looked into fixing this a while ago, and it seemed like the behavior of geolocation had changed (to always ask the user by default). So I thought then that we were going to have to rewrite the whole thing. But it looks like I was mistaken.

I think this change only updates the first revision, so the next two (the one that includes the check, and the one packaged as a separate module) still don't work.

Comment 3

[Will Bamberg [:wbamberg]]

Attachment: mdn.html

Comment 4

[Will Bamberg [:wbamberg]]

It looks to me as if, at least in some Firefox versions, geolocation now always prompts the user. Which makes this example kind of pointless. So I rewrote it to be a different example, using nsIFilePicker and nsICryptoHash. It's a bit boring, but at least it's correct.

Comment 5

[Tomislav Jovanovic :zombie]

Comment on attachment 8406409 [details]
mdn.html

Will, sorry i didn't finish this, but i couldn't get geolocation to work on my computer, even with the prompting, so this is probably better.

this looks good to me. i fixed a few small nits (indentation and some dead code), since that seemed quicker and easier than listing them here (we don't have a good comment/review system for mdn).

and just a note, it might be a good idea to give an example module that could be reused outside of jetpack (since we are using commonJS modules). so if we ever need to revisit this tutorial (again), might as well not use XPCOM.