Closed
Bug 943141
Opened 11 years ago
Closed 11 years ago
Set breakpad symbols dir for B2G ./mach mochitest-remote
Categories
(Testing :: Mochitest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: jld, Assigned: jld)
Details
Attachments
(1 file, 1 obsolete file)
1.11 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
Desktop mochitests set options.symbolsPath to the place where `./mach buildsymbols` leaves the symbols; B2G should do the same thing (except it's `./build.sh buildsymbols`, and we get symbols from the rest of the system).
Note that you still need to bring your own minidump_stackwalk for this to be useful.
Attachment #8338141 -
Flags: review?(jgriffin)
Comment 1•11 years ago
|
||
Comment on attachment 8338141 [details] [diff] [review]
bugNNNNNN-b2g-mochi-symbols-hg0.diff
Review of attachment 8338141 [details] [diff] [review]:
-----------------------------------------------------------------
I'm passing this to ahal, who knows this code better than me.
Attachment #8338141 -
Flags: review?(jgriffin) → review?(ahalberstadt)
Comment 2•11 years ago
|
||
Comment on attachment 8338141 [details] [diff] [review]
bugNNNNNN-b2g-mochi-symbols-hg0.diff
Review of attachment 8338141 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, with one comment.
::: testing/mochitest/mach_commands.py
@@ +149,5 @@
> options.noWindow = no_window
> options.totalChunks = total_chunks
> options.thisChunk = this_chunk
>
> + options.symbolsPath = os.path.join(self.distdir, 'crashreporter-symbols')
What does minidump_stackwalk do if the symbols path doesn't exist? We should probably check for existence before setting it.
Attachment #8338141 -
Flags: review?(ahalberstadt) → review+
Comment 3•11 years ago
|
||
It doesn't actually check the symbol path, it will just fail to find symbols and give you a non-symbolicated stack.
Comment 4•11 years ago
|
||
Ok, feel free to disregard the comment if that's the desired behaviour.
Assignee | ||
Comment 5•11 years ago
|
||
This is literally copied and pasted from run_desktop_test, so if we think that one of them should emit a warning if there aren't symbols, then that presumably applies to both of them. And that would be a separate bug, I think.
Assignee | ||
Comment 6•11 years ago
|
||
Updating commit message for bug number and r-ness; no change to diff. Carrying over r+(ahal).
Attachment #8338141 -
Attachment is obsolete: true
Attachment #8338797 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Summary: Set up breakpad symbols test for B2G ./mach mochitest-remote → Set breakpad symbols dir for B2G ./mach mochitest-remote
Comment 8•11 years ago
|
||
Keywords: checkin-needed
Comment 9•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•