Closed Bug 943141 Opened 11 years ago Closed 11 years ago

Set breakpad symbols dir for B2G ./mach mochitest-remote

Categories

(Testing :: Mochitest, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: jld, Assigned: jld)

Details

Attachments

(1 file, 1 obsolete file)

Desktop mochitests set options.symbolsPath to the place where `./mach buildsymbols` leaves the symbols; B2G should do the same thing (except it's `./build.sh buildsymbols`, and we get symbols from the rest of the system). Note that you still need to bring your own minidump_stackwalk for this to be useful.
Attachment #8338141 - Flags: review?(jgriffin)
Comment on attachment 8338141 [details] [diff] [review] bugNNNNNN-b2g-mochi-symbols-hg0.diff Review of attachment 8338141 [details] [diff] [review]: ----------------------------------------------------------------- I'm passing this to ahal, who knows this code better than me.
Attachment #8338141 - Flags: review?(jgriffin) → review?(ahalberstadt)
Comment on attachment 8338141 [details] [diff] [review] bugNNNNNN-b2g-mochi-symbols-hg0.diff Review of attachment 8338141 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, with one comment. ::: testing/mochitest/mach_commands.py @@ +149,5 @@ > options.noWindow = no_window > options.totalChunks = total_chunks > options.thisChunk = this_chunk > > + options.symbolsPath = os.path.join(self.distdir, 'crashreporter-symbols') What does minidump_stackwalk do if the symbols path doesn't exist? We should probably check for existence before setting it.
Attachment #8338141 - Flags: review?(ahalberstadt) → review+
It doesn't actually check the symbol path, it will just fail to find symbols and give you a non-symbolicated stack.
Ok, feel free to disregard the comment if that's the desired behaviour.
This is literally copied and pasted from run_desktop_test, so if we think that one of them should emit a warning if there aren't symbols, then that presumably applies to both of them. And that would be a separate bug, I think.
Updating commit message for bug number and r-ness; no change to diff. Carrying over r+(ahal).
Attachment #8338141 - Attachment is obsolete: true
Attachment #8338797 - Flags: review+
→ b2g-inbound.
Keywords: checkin-needed
Summary: Set up breakpad symbols test for B2G ./mach mochitest-remote → Set breakpad symbols dir for B2G ./mach mochitest-remote
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: