Set breakpad symbols dir for B2G ./mach mochitest-remote

RESOLVED FIXED in mozilla28

Status

Testing
Mochitest
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jld, Assigned: jld)

Tracking

unspecified
mozilla28
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 8338141 [details] [diff] [review]
bugNNNNNN-b2g-mochi-symbols-hg0.diff

Desktop mochitests set options.symbolsPath to the place where `./mach buildsymbols` leaves the symbols; B2G should do the same thing (except it's `./build.sh buildsymbols`, and we get symbols from the rest of the system).

Note that you still need to bring your own minidump_stackwalk for this to be useful.
Attachment #8338141 - Flags: review?(jgriffin)
Comment on attachment 8338141 [details] [diff] [review]
bugNNNNNN-b2g-mochi-symbols-hg0.diff

Review of attachment 8338141 [details] [diff] [review]:
-----------------------------------------------------------------

I'm passing this to ahal, who knows this code better than me.
Attachment #8338141 - Flags: review?(jgriffin) → review?(ahalberstadt)
Comment on attachment 8338141 [details] [diff] [review]
bugNNNNNN-b2g-mochi-symbols-hg0.diff

Review of attachment 8338141 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, with one comment.

::: testing/mochitest/mach_commands.py
@@ +149,5 @@
>          options.noWindow = no_window
>          options.totalChunks = total_chunks
>          options.thisChunk = this_chunk
>  
> +        options.symbolsPath = os.path.join(self.distdir, 'crashreporter-symbols')

What does minidump_stackwalk do if the symbols path doesn't exist? We should probably check for existence before setting it.
Attachment #8338141 - Flags: review?(ahalberstadt) → review+
It doesn't actually check the symbol path, it will just fail to find symbols and give you a non-symbolicated stack.
Ok, feel free to disregard the comment if that's the desired behaviour.
(Assignee)

Comment 5

4 years ago
This is literally copied and pasted from run_desktop_test, so if we think that one of them should emit a warning if there aren't symbols, then that presumably applies to both of them.  And that would be a separate bug, I think.
(Assignee)

Comment 6

4 years ago
Created attachment 8338797 [details] [diff] [review]
bug943141-b2g-mochi-symbols-hg1.diff

Updating commit message for bug number and r-ness; no change to diff.  Carrying over r+(ahal).
Attachment #8338141 - Attachment is obsolete: true
Attachment #8338797 - Flags: review+
(Assignee)

Comment 7

4 years ago
→ b2g-inbound.
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Summary: Set up breakpad symbols test for B2G ./mach mochitest-remote → Set breakpad symbols dir for B2G ./mach mochitest-remote
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e8a05a828fa
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5e8a05a828fa
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.