Closed Bug 943159 Opened 6 years ago Closed 6 years ago

Remove MOZ_SPEEX_RESAMPLER/MOZ_SOUNDTOUCH defines since we don't support building without them anyway

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: 943161
That'll teach me for pushing on top of a larger, riskier patch.

https://tbpl.mozilla.org/?tree=Try&rev=e2343a2e07ee
Attachment #8338170 - Attachment is obsolete: true
Attachment #8339722 - Flags: review?(chris.double)
Comment on attachment 8339722 [details] [diff] [review]
bug943159_v1.patch

Review of attachment 8339722 [details] [diff] [review]:
-----------------------------------------------------------------

r+ from me but I'm not a build peer so don't know how much that accounts for.
Attachment #8339722 - Flags: review?(chris.double) → review+
Comment on attachment 8339722 [details] [diff] [review]
bug943159_v1.patch

It's a simple removal, but I'm not clear on the rules for when build peers need to review, so adding r? gps.
Attachment #8339722 - Flags: review?(gps)
Comment on attachment 8339722 [details] [diff] [review]
bug943159_v1.patch

Review of attachment 8339722 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8339722 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/21bce5b41a7c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.