943159 - Remove MOZ_SPEEX_RESAMPLER/MOZ_SOUNDTOUCH defines since we don't support building without them anyway

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: bug943159_v0.patch

https://tbpl.mozilla.org/?tree=Try&rev=c3b5b8fef830

Comment 2

[Matthew Gregan [:kinetik]]

That'll teach me for pushing on top of a larger, riskier patch.

https://tbpl.mozilla.org/?tree=Try&rev=e2343a2e07ee

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: bug943159_v1.patch

Comment 4

[cajbir (:cajbir)]

Comment on attachment 8339722 [details] [diff] [review]
bug943159_v1.patch

Review of attachment 8339722 [details] [diff] [review]:
-----------------------------------------------------------------

r+ from me but I'm not a build peer so don't know how much that accounts for.

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8339722 [details] [diff] [review]
bug943159_v1.patch

It's a simple removal, but I'm not clear on the rules for when build peers need to review, so adding r? gps.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8339722 [details] [diff] [review]
bug943159_v1.patch

Review of attachment 8339722 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 7

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21bce5b41a7c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21bce5b41a7c