943208 - Stop force-enabling logging for ftp on Windows, so it can be built unified

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Phil Ringnalda (:philor)]

Bug 941854 added protection against a couple of known-bad things to do in unified source, one of them being force-enabling NSPR logging. Then it bounced, and relanded burning, because in April 1999 valeski wanted to have logging force-enabled in Windows release builds for ftp, so http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Fnetwerk%2Fprotocol%2Fftp%2Fsrc%2FAttic%2Fmakefile.win&rev=&cvsroot=%2Fcvsroot and we've been dragging that around with us ever since, down to http://hg.mozilla.org/mozilla-central/annotate/default/netwerk/protocol/ftp/Makefile.in#l13

We should stop, valeski no longer needs his Windows ftp logging.

In the meantime, I landed https://hg.mozilla.org/integration/mozilla-inbound/rev/e6e17a2ffab6 as a bustage fix, losing ftp the benefits of unified building.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: stahp

I tried to make sure he was done with this logging, I said "valeski: ping" but he didn't answer :)

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8338281 [details] [diff] [review]
stahp

Review of attachment 8338281 [details] [diff] [review]:
-----------------------------------------------------------------

yow - that's an artifact.

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1f81156091e

Comment 4

[(no longer active)]

Thanks for doing this, Phil! :-)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f1f81156091e