Closed Bug 943208 Opened 6 years ago Closed 6 years ago

Stop force-enabling logging for ftp on Windows, so it can be built unified

Categories

(Core :: Networking: FTP, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: philor, Assigned: philor)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Bug 941854 added protection against a couple of known-bad things to do in unified source, one of them being force-enabling NSPR logging. Then it bounced, and relanded burning, because in April 1999 valeski wanted to have logging force-enabled in Windows release builds for ftp, so http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Fnetwerk%2Fprotocol%2Fftp%2Fsrc%2FAttic%2Fmakefile.win&rev=&cvsroot=%2Fcvsroot and we've been dragging that around with us ever since, down to http://hg.mozilla.org/mozilla-central/annotate/default/netwerk/protocol/ftp/Makefile.in#l13

We should stop, valeski no longer needs his Windows ftp logging.

In the meantime, I landed https://hg.mozilla.org/integration/mozilla-inbound/rev/e6e17a2ffab6 as a bustage fix, losing ftp the benefits of unified building.
Attached patch stahpSplinter Review
I tried to make sure he was done with this logging, I said "valeski: ping" but he didn't answer :)
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #8338281 - Flags: review?(mcmanus)
Comment on attachment 8338281 [details] [diff] [review]
stahp

Review of attachment 8338281 [details] [diff] [review]:
-----------------------------------------------------------------

yow - that's an artifact.
Attachment #8338281 - Flags: review?(mcmanus) → review+
Thanks for doing this, Phil! :-)
Blocks: unified
https://hg.mozilla.org/mozilla-central/rev/f1f81156091e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.