Closed
Bug 943235
Opened 9 years ago
Closed 9 years ago
logging.h:95:0: warning: "LOG" redefined, when building xpcom/io in unified mode
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
883 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Build warning, when building in unified mode: { 0:04.72 In file included from /scratch/work/builds/mozilla-inbound/mozilla/ipc/chromium/src/base/command_line.h:27:0, 0:04.72 from /scratch/work/builds/mozilla-inbound/mozilla/ipc/chromium/src/base/process_util.h:28, 0:04.72 from ../../dist/include/ipc/IPCMessageUtils.h:10, 0:04.72 from /scratch/work/builds/mozilla-inbound/mozilla/xpcom/io/nsStringStream.cpp:11, 0:04.72 from /scratch/work/builds/mozilla-inbound/obj/xpcom/io/Unified_cpp_xpcom_io1.cpp:29: 0:04.72 Warning: enabled by default in /scratch/work/builds/mozilla-inbound/mozilla/ipc/chromium/src/base/logging.h: "LOG" redefined 0:04.72 /scratch/work/builds/mozilla-inbound/mozilla/ipc/chromium/src/base/logging.h:95:0: warning: "LOG" redefined [enabled by default] 0:04.72 #define LOG(info) mozilla::LogWrapper(mozilla::LOG_ ## info, __FILE__, __LINE__) 0:04.72 ^ 0:04.72 In file included from /scratch/work/builds/mozilla-inbound/obj/xpcom/io/Unified_cpp_xpcom_io1.cpp:11:0: 0:04.72 /scratch/work/builds/mozilla-inbound/mozilla/xpcom/io/nsStorageStream.cpp:51:0: note: this is the location of the previous definition 0:04.72 #define LOG(args) PR_LOG(GetStorageStreamLog(), PR_LOG_DEBUG, args) 0:04.72 ^ } nsStorageStream.cpp already has an #undef at the top to be sure its LOG() definition is the only one. HOWEVER, when we build in unified mode, its LOG definition leaks into stuff that's concatenated to the .cpp file *after* it, and we end up complaining about LOG being redefined there as a result. The obvious fix is to just #undef LOG at the end of nsStorageStream.cpp.
Assignee | ||
Updated•9 years ago
|
Blocks: buildwarning
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8338310 -
Attachment description: 943235-fix.patch → fix v1
![]() |
||
Updated•9 years ago
|
Attachment #8338310 -
Flags: review?(nfroyd) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/150932cb83bf
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Flags: in-testsuite-
Assignee | ||
Updated•9 years ago
|
Summary: logging.h:95:0: warning: "LOG" redefined [enabled by default], when building xpcom/io in unified mode → logging.h:95:0: warning: "LOG" redefined, when building xpcom/io in unified mode
https://hg.mozilla.org/mozilla-central/rev/150932cb83bf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•9 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•