Closed Bug 943269 Opened 11 years ago Closed 10 years ago

Intermittent TEST-UNEXPECTED-FAIL | /tests/layout/forms/test/test_bug402198.html | application timed out after 330 seconds with no output

Categories

(Core :: Layout: Form Controls, defect, P5)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox31 --- fixed
firefox32 --- fixed
firefox33 --- fixed
firefox-esr24 --- unaffected
b2g-v1.3 --- wontfix
b2g-v1.3T --- wontfix
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: cbook, Assigned: MatsPalmgren_bugz)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

b2g_ubuntu64_vm b2g-inbound opt test mochitest-1 on 2013-11-25 07:16:41 PST for push 261e064c07d7

slave: tst-linux64-ec2-066

https://tbpl.mozilla.org/php/getParsedLog.php?id=31045645&tree=B2g-Inbound

TEST-UNEXPECTED-FAIL | /tests/layout/forms/test/test_bug402198.html | application timed out after 330 seconds with no output
TEST-UNEXPECTED-FAIL | /tests/layout/forms/test/test_bug402198.html | application terminated with exit code 1536
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug402198.html?force=1

59   SimpleTest.finish();
60   setTimeout(function() {document.body.style.display = '';}, 400);

That looks strange; I don't think we should be doing things after calling finish().
I don't see how it could cause a hang though.
Anyway, I don't see "this is a crash/assertion test..." in the log so I guess
we didn't reach line 58, unless we failed to flush that out before we were
killed by the framework.

Fwiw, we should probably change the above to:
setTimeout(function() {document.body.style.display = ''; SimpleTest.finish();}, 400);
Priority: -- → P5
Line 60 wasn't in the original check-in, it was added in:
http://hg.mozilla.org/mozilla-central/diff/37dd897d1c32/layout/forms/test/test_bug402198.html

Martijn, do you remember why you added that line? and do you think the suggested change above
would work?
Flags: needinfo?(martijn.martijn)
(In reply to Mats Palmgren (:mats) from comment #2)
> Line 60 wasn't in the original check-in, it was added in:
> http://hg.mozilla.org/mozilla-central/diff/37dd897d1c32/layout/forms/test/
> test_bug402198.html
> 
> Martijn, do you remember why you added that line? and do you think the
> suggested change above
> would work?

I think I added it while I was running it as a standalone mochitest, to be able to see the result of the mochitest. I was afraid it would otherwise interfere with the test (in the sense that it wouldn't crash when this issue still occured in the browser).
This shouldn't cause these failures. Anyway, the last time this happened (4 monts ago), it wasn't a timeout, but a crash.
Flags: needinfo?(martijn.martijn)
Attached patch fixSplinter Review
OK, I think we should try this then.

(The crash in comment 5 has "exit code 6" so I'm pretty sure
it's the test framework that intentionally aborted the process
when it detected the timeout.)

https://tbpl.mozilla.org/?tree=Try&rev=c39c56451a28
Attachment #8454909 - Flags: review?(martijn.martijn)
Comment on attachment 8454909 [details] [diff] [review]
fix

Review of attachment 8454909 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that should be fine. However, like I said, I don't think it should fix this intermittent failure.
Attachment #8454909 - Flags: review?(martijn.martijn) → review+
(In reply to Martijn Wargers [:mwargers] (QA) from comment #8)
> However, like I said, I don't think it should
> fix this intermittent failure.

Yeah, maybe not, we'll see.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c53d310a64e9
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/c53d310a64e9
Assignee: nobody → mats
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: