943283 - Locale-specific JS number/date formatting should not make a trip through non-UTF encodings

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Henri Sivonen (:hsivonen)]

XPCLocale.cpp assumes that locale-specific number/date formatting may go through a locale-dependent non-UTF encoding. This makes no sense in 2013 and gets in the way of removing nsIPlatformCharseet. Locale-specific number/date formatting  should be possible using Unicode APIs only--possibly ICU.

Comment 1

[Masatoshi Kimura [:emk]]

We need to rewrite PRMJ_FormatTime so that it doesn't depend on CRT strftime which will return non-UTF-8 string on Windows, even in 2013.

Comment 2

[Masatoshi Kimura [:emk]]

An easiest solution would be using wcsftime on WIndows.

Comment 3

[Henri Sivonen (:hsivonen)]

It seems that the right way to fix this in to fix bug 866344 and then remove the resulting dead code.

Comment 4

[Makoto Kato [:m_kato]]

After landing bug 1346674 and bug 1349470, we don't use NS_ILOCALE_DATE.  So we can replace it with NS_CopyNativeToUnicode simply.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 943283 - Use NS_CopyNativeToUnicode instead of nsIUnicodeDecoder.

By bug 1346674, we don't use NSILOCALE_* for unicode conversion in XPC/JS.  So we should use NS_CopyNativeToUnicode to get a rid of nsIPlatformCharset.

Review commit: https://reviewboard.mozilla.org/r/124192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124192/

Comment 6

[Jonathan Kew [:jfkthame]]

Comment on attachment 8851938 [details]
Bug 943283 - Use NS_CopyNativeToUnicode instead of nsIUnicodeDecoder.

https://reviewboard.mozilla.org/r/124192/#review126732

So according to the header (nsNativeCharsetUtils.h), NS_CopyNativeToUnicode "should only be used for converting *FILENAMES*...". However, in practice I think it's fine here, given the very limited scope where it's used.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35caf320cf70
Use NS_CopyNativeToUnicode instead of nsIUnicodeDecoder. r=jfkthame

Comment 8

[Iris Hsiao [:ihsiao]]

sorry had to back this out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=87140618&repo=autoland&lineNumber=14358

https://hg.mozilla.org/integration/autoland/rev/a9d7ba18975f

Comment 9

[Makoto Kato [:m_kato]]

I should remove unused rv.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c24ffa3f69e
Use NS_CopyNativeToUnicode instead of nsIUnicodeDecoder. r=jfkthame

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c24ffa3f69e