943296 - widget/gtk/nsDragService.cpp should assume Gtk uses UTF-8

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Henri Sivonen (:hsivonen)]

widget/gtk/nsDragService.cpp calls nsPrimitiveHelpers::ConvertPlatformPlainTextToUnicode and nsPrimitiveHelpers::ConvertUnicodeToPlatformPlainText. Since we already assume that *nix  platforms use UTF-8 as the platform  encoding these days, nsDragService should just assume UTF-8, too.

Comment 1

[Henri Sivonen (:hsivonen)]

(In reply to Henri Sivonen (:hsivonen) from comment #0)
> Since we already
> assume that *nix  platforms use UTF-8 as the platform  encoding these days,
> nsDragService should just assume UTF-8, too.

That's not quite the right reason to fix this. The right reason is that for APIs other than those that deal with file system paths, Gtk has been UTF-8-only since version 2. The code in question here was migrated from Gtk1 until in compiled under Gtk2--leaving around cruft that was no longer needed or even correct--when it should have been rewritten as UTF-8-only for Gtk2 like nsClipboard.cpp was during the Gtk2 migration.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Assume UTF-8

The old code uses C strings instead of XPCOM strings. That's sad but out of scope for this patch.

Comment 3

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbc553ea0021

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Assume UTF-8, v2

Comment 5

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f393144e890d

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8672971 [details] [diff] [review]
Assume UTF-8, v2

As you hint, this should all be replaced by gtk_selection_data_set_text()/_get_text()/_uris(), a bit like nsClipboard.
Some code could even be shared.

This patch is kind of a step in that direction, thanks.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07fe0365048c

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07fe0365048c