943298 - In SIM import-export contacts flows avoid creating new entries in the SIM card

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

When a Contact is imported from the SIM card we should keep the contact id that the iccManager module is providing. With this simple approach we are avoiding contact duplicates in import-export flows.

Please note that this does not solve all the SIM export duplicates problems as a local contact - export - import flow cannot be solved until bug 943234 lands and its corresponding Gaia patch. 

Nominating this as it will be a really simple patch but at the same time will be a quick win for avoiding SIM duplications.

Comment 1

[Preeti Raghunath(:Preeti)]

Please renom for later release. This is a feature enhancement so no 1.2 or 1.3.

Comment 2

[Jose Manuel Cantera]

Attachment: 14163.html - Patch for v1.2 version

Comment 3

[Jose Manuel Cantera]

(In reply to Jose M. Cantera from comment #2)
> Created attachment 8339780 [details]
> 14163.html - Patch for v1.2 version

The user gain having this patch uplifted to v1.2 is huge. ni Ayman to confirm this.

Comment 4

[ayman maat :maat]

As Jose rightly states, the user gain due to the presence of this patch is immense. 

...from a UX PoV Anything that reduces the possibility (and therefore the number) of duplicate contact being created in the contact list when contacts are imported from the SIM is highly beneficial to our users. It keeps their data clean, and reduces the amount of effort that the user must expend (and therefore frustration they experience) to clean up their contact list after import. In view of this I would recommend to uplift for V1.2

Good work Jose

Comment 5

[Jose Manuel Cantera]

Attachment: 14170.html (patch for master)

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8339780 [details]
14163.html - Patch for v1.2 version

Looking great to me, just left a comment on github.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8339842 [details]
14170.html (patch for master)

Same here, thanks for the job!

Comment 8

[Jose Manuel Cantera]

landed on master: https://github.com/mozilla-b2g/gaia/commit/7d5397653b6098a63f461e2b89aa2e5386b1deca

Comment 9

[Jose Manuel Cantera]

Comment on attachment 8339780 [details]
14163.html - Patch for v1.2 version

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not properly managing contactIds provided by the moziccManager API. 
[User impact] if declined: Very high. High number of contact duplications while exporting 
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Very low risk patch 
[String changes made]: contactId returned by iccManager.readContacts while importing is saved in the mozContact object for later reusing it

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8339780 [details]
14163.html - Patch for v1.2 version

We need this patch as has been addressed in the request, way to many duplicated contacts while importing.

a=me

Comment 11

[Jose Manuel Cantera]

landed in v1.2

https://github.com/mozilla-b2g/gaia/commit/395db5713ecc24398c607fe348978209f822146c

Comment 12

[Jose Manuel Cantera]

ready to be tested by QA