Closed Bug 943321 Opened 11 years ago Closed 11 years ago

[Shared] Followup: remove drop shadows from action icons

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: epang, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, jian)

Attachments

(3 files)

Attached file shared.zip
Hey Pavel, as Borja pointed out in bug 939153 it looks like an icon was added with a drop shadow after our first bug was landed for shared icons.  I've updated the icon set in the attached, can you overwrite? Thanks!
Attached file patch for Gaia/master
As Vivien told ... I can ask you for r+ for image swap :)
Attachment #8338798 - Flags: review?(epang)
that's great, but speaking we Casey we noticed there were a few icons that overwrote some of his changes.. so I've updated the files again.  Sorry.  Please flag me when ready!  Thanks!
Flags: needinfo?(pivanov)
Done :)
Flags: needinfo?(pivanov) → needinfo?(epang)
Comment on attachment 8338798 [details] [review]
patch for Gaia/master

Looks good!  Let's land this!
Attachment #8338798 - Flags: review?(epang) → review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/7e2f00aaeb3d5704a925fa0e85d95c3a8ff08261
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: needinfo?(epang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: