Closed Bug 943351 Opened 8 years ago Closed 8 years ago
Performance regression in canvas stroke
There is strange canvas strokeText slowness in Nightly and Aurora. Calling strokeText repeatedly causes the browser to spike to 100% CPU and triggers the unresponsive script prompt. The issue occurs on both of the Linux PCs I've tested (I haven't tried any other OS). A small reproduction program can be found at http://jsfiddle.net/sT8RF/1/ Profiling data for the above page is at http://people.mozilla.org/~bgirard/cleopatra/#report=31e9133800d7d680923ae0ce8437b5161a2cddad mozregression narrows down the regression to: Last good nightly: 2013-09-28 First bad nightly: 2013-09-29 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2f4397db1830&tochange=8f805d3ef377
Thanks for the regression. I'm eye balling this to bug 918613. Bas is still likely?
This should block because the regression is very large. We went from ~300ms to 12 seconds for the test case.
Assignee: nobody → bas
Status: NEW → ASSIGNED
Attachment #8338590 - Flags: review?(bgirard)
Attachment #8338590 - Flags: review?(bgirard) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
We are going to track this due to our concern for the impact on users and ask for an uplift to aurora.
(In reply to Bas Schouten (:bas.schouten) from comment #5) > https://hg.mozilla.org/integration/mozilla-inbound/rev/a1523aeef7d8 Bas, is this ready to uplift on aurora ?
Comment on attachment 8338590 [details] [diff] [review] Make sure to clear any existing paths before getting the glyph path off a context. [Approval Request Comment] Bug caused by (feature/regressing bug #): 918613 User impact if declined: Incorrect rendering of stroked text in some cases. Testing completed (on m-c, etc.): On nightly for 2 weeks. Risk to taking this patch (and alternatives if risky): Very low. String or IDL/UUID changes made by this patch: None
Attachment #8338590 - Flags: approval-mozilla-aurora?
Attachment #8338590 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Erik, can you please confirm this is fixed for you now in Firefox 28 and 29?
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #10) > Erik, can you please confirm this is fixed for you now in Firefox 28 and 29? Yes. It's fixed in both Aurora (version 28 - Dec 19 2013) and Nightly (version 29 - Dec 19, 2013)
NI on Bas to help with uplift on Firefox 27.
Comment on attachment 8338590 [details] [diff] [review] Make sure to clear any existing paths before getting the glyph path off a context. [Approval Request Comment] See Aurora approval request. It seems I've failed to uplift this to aurora :(. Let's uplift it to beta then. It should be very safe and it's had extensive testing on nightly and Aurora.
Attachment #8338590 - Flags: approval-mozilla-beta?
Attachment #8338590 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.