943373 - Use MOZ_THIS_IN_INITIALIZER_LIST instead of the pragma disabling the check

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Andrew McCreight [:mccr8]]

Ms2ger pointed that MOZ thing out.  See bug 770535 comment 10 for the two places where this is currently happening, though it would be good to make sure with a Windows try push that that is all there is.  Once those are converted, the pragma in xpcprivate can be removed.

Comment 1

[Andrew McCreight [:mccr8]]

Let's generalize this a little.  There aren't many places that are using this.

Comment 2

[Andrew McCreight [:mccr8]]

https://tbpl.mozilla.org/?tree=Try&rev=8e8112629714

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Use MOZ_THIS_IN_INITIALIZER_LIST in XPConnect. r=bholley

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Use MOZ_THIS_IN_INITIALIZER_LIST in SVG-ish stuff. r=birtles

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Use MOZ_THIS_IN_INITIALIZER_LIST with nsINode. r=bholley

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Use MOZ_THIS_IN_INITIALIZER_LIST in the JS engine. r=Waldo

Comment 7

[Andrew McCreight [:mccr8]]

Green try run: https://tbpl.mozilla.org/?tree=Try&rev=8e8112629714

After these patches, the only uses left that I see talking about 4355 are in WebRTC and various imported code.

Comment 8

[Masatoshi Kimura [:emk]]

Have you verified that these "this" in constructors are safe? If not, we should just disable the warning globally (perhaps in the build config). If people just silence the warning, it will only uglify the source.

Comment 9

[Masatoshi Kimura [:emk]]

FYI MSVC11+ disabled this warning by default.

Comment 10

[Andrew McCreight [:mccr8]]

(In reply to Masatoshi Kimura [:emk] from comment #8)
> Have you verified that these "this" in constructors are safe? If not, we
> should just disable the warning globally (perhaps in the build config). If
> people just silence the warning, it will only uglify the source.

I did.  People are just sticking raw pointers to |this| in the data structures without calling any method on them.

Comment 11

[Andrew McCreight [:mccr8]]

Landed the first three parts.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6f67a0fa584a
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/31def8a3dfca
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/22d0b15b74c9

Comment 12

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/74a403c9141f

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f67a0fa584a
https://hg.mozilla.org/mozilla-central/rev/31def8a3dfca
https://hg.mozilla.org/mozilla-central/rev/22d0b15b74c9
https://hg.mozilla.org/mozilla-central/rev/74a403c9141f