943431 - Separate resource files in Thimble and Goggles

Status: RESOLVED FIXED

(Webmaker Graveyard :: Localization, defect)

Description

[Ali Al Dallal [:alicoding]]

We are separating these files so that it can be easily translate and if we want we can share them as well.

Comment 1

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/69

Comment 2

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/301

Comment 3

[David Humphrey (:humph)]

Can we drop the thimble-* and goggles-* prefix and only do 1 file?  Probably needs another bug, right?

Also, there is a bunch of crap in the html, e.g., "<span style=\"font-family: Courier New;\">" that we should just do with CSS, no?  Seems odd to have that in there.

There are rel="internal" and title="..." things too.  Should we remove those while we're in these files?

Comment 4

[Ali Al Dallal [:alicoding]]

I'm actually going to have another bug to clean up them (title=, rel= and those inline CSS) and the file names going to be change in another bug.

Comment 5

[David Humphrey (:humph)]

Sounds good.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/ec42bfe7d4931c4afd31b5e807eb9acd523ee606
Bug 943431 - Separate resource files in Thimble and Goggles

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org

https://github.com/mozilla/goggles.webmaker.org/commit/509fb1a87c6e15fa53aa8963cdf86d58b4a08a07
Bug 943431 - Separate resource files in Thimble and Goggles