943441 - test_import_contacts_from_gmail is failing on master for the wrong reason (the locator has changed)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

this is failing on jenkins for the wrong reason 

a locator has changed
the switch to frame is doing the wrong thing

Comment 1

[Florin Strugariu [:Bebe]]

http://qa-selenium.mv.mozilla.com:8080/view/B2G%20Hamachi/job/b2g.hamachi.mozilla-central.ui/322/testReport/junit/test_import_contacts_from_gmail/TestImportContactsFromGmail/test_import_contacts_from_gmail/history/?

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14074

Pointer to Github pull-request

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8338592 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14074

r+, but with a question in the PR.

Comment 4

[Zac C (:zac)]

Comment on attachment 8338592 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14074

r+ too!

Comment 5

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/0d32fbd1bbfb120f6188f8f19c10f546581a3633

Bebe is this valid for v1.2?

Comment 6

[Florin Strugariu [:Bebe]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14269

Pointer to Github pull-request

Comment 7

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8341152 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14269

r+

Comment 8

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8341152 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14269

We need to wait for the tree to reopen in order to merge this.

Comment 9

[Trif Andrei-Alin[:AlinT]]

Landed in v1.2:
https://github.com/mozilla-b2g/gaia/commit/af650d04dd69685c571f983722d0967f010dcc8c