943471 - Getting Payment Cancelled (500 from API /api/v1/webpay/prepare) trying to buy an app

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[[e-mail]]

Looks like changes in https://github.com/mozilla/zamboni/commit/a4a74199f48792faaa5995a803f3751e3aba7525 have broken payments.

I see the following in logcat output:

E/GeckoConsole( 3916): Content JS LOG at http://mp.mozilla.dev/media/js/log.js:51 in anonymous: [req] POSTing http://mp.mozilla.dev/api/v1/webpay/prepare/<redacted>
E/GeckoConsole( 3916): Content JS LOG at http://mp.mozilla.dev/media/js/log.js:51 in anonymous: [req] Request failed: POST 500
E/GeckoConsole( 3916): Content JS LOG at http://mp.mozilla.dev/media/js/log.js:51 in anonymous: [req] Error message:  'NoneType' object has no attribute 'pk'
E/GeckoConsole( 3916): Content JS ERROR at http://mp.mozilla.dev/media/js/log.js:51 in anonymous: [payments] Error fetching JWT from API:  INTERNAL SERVER ERROR 500
E/GeckoConsole( 3916): Content JS LOG at http://mp.mozilla.dev/media/js/log.js:51 in anonymous: [buttons] Purchase flow rejected for Test App (bison9550)
E/GeckoConsole( 3916): Content JS LOG at http://mp.mozilla.dev/media/js/log.js:51 in anonymous: [buttons] Unsuccessful install for Test App (bison9550)

When directly posting with curl I see the following error message:

{"app":["This field is required."]}

Comment 1

[[e-mail]]

Additional STR:

With a phone pointing at a local dev env attempt to buy an app. (Note: This might happen in -dev too, I've just not got certs installed presently to try it.)

What happens:

 * You immediately see "Payment cancelled"
 
What should happen:

 * You should start the payment flow.

Comment 2

[krupa raj[:krupa]]

This happens on dev as well.

Comment 3

[Mathieu Pillard [:mat]]

Breakage probably comes from https://github.com/mozilla/zamboni/commit/c1e9833cfd42244549339079b47bd6130f486dd5

Comment 4

[Mathieu Pillard [:mat]]

Pull request with the fix up for review : https://github.com/mozilla/zamboni/pull/1454

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/6a97b4e2d2fa6384fb5068cc076c1273c0c3eb16

Comment 6

[Victor Carciu]

Mathieu, can you please help me to correctly understand the STRs for this bug?

Comment 7

[Victor Carciu]

After discussing with Mathieu on IRC, I tested the bug by purchasing an app on Stage starting logged in in and then logged out. 

Verified as fixed