943472 - esFrontLine treats empty path components incorrectly

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

There is a check in esFrontline to match requests paths like:

/indexname/_search
/indexname/_mappings

This should prevent requests like:

/indexname/_stats

However, by appending an empty path element as follows:

/bugs/_stats/

The filter() fuction passes it as valid and gives it straight to ES.

(It counts 3 request path elements and thus passes the test)

Example:

curl --silent --compressed -XGET http://klahnakoski-es.corp.tor1.mozilla.com:9292/bugs/_stats/ | python -mjson.tool
{
    "_all": {
        "indices": {
            "bugs20130722": {
                "primaries": {
                    "docs": {
                        "count": 34732792,
                        "deleted": 373919
                    },
...

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Same trick to execute commands with just one path component:

I was able to discover all indexes as follows:

curl --silent --compressed -XGET http://klahnakoski-es.corp.tor1.mozilla.com:9292/_stats// | python -mjson.tool
{
    "_all": {
        "indices": {
            "bug_summary130510_172316": {
                "primaries": {
                    "docs": {
                        "count": 893004,
                        "deleted": 0
                    },
...

Comment 2

[Kyle Lahnakoski [:ekyle]]

previous bug (https://bugzilla.mozilla.org/show_bug.cgi?id=943465) fixed this


test

https://github.com/klahnakoski/esFrontLine/commit/ae0f19e34bbc679546b2b901a55e426278e915ae#diff-4f1490608dfd64f043e4585063a302bdR25