Don't print the overall summary for shutdown leak detector failures, since it is redundant

RESOLVED FIXED in mozilla28

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

unspecified
mozilla28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
A typical failure found by the new (/reinstated) shutdown leak detector is:

{
TEST-UNEXPECTED-FAIL | ShutdownLeaks | leaked 2 DOMWindow(s) and 0 DocShell(s) until shutdown
TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_url.js | leaked 1 window(s) until shutdown [url = chrome://mozapps/content/xpinstall/xpinstallConfirm.xul]
TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_url.js | leaked 1 window(s) until shutdown [url = about:blank]
}

The first line:
* is superfluous noise when using TBPL
* encourages people filing intermittent-failure bugs to cram more cruft into the summary than they already do
* causes false positives when TBPL searches for the test name "ShutdownLeaks" (I can blacklist this in TBPL, but we should just remove it as it is redundant)
(Assignee)

Updated

5 years ago
Blocks: 910614
(Assignee)

Comment 1

5 years ago
Attachment #8338660 - Flags: review?(ttaubert)
Comment on attachment 8338660 [details] [diff] [review]
Remove summary

Review of attachment 8338660 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable to me.
Attachment #8338660 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/dcdf76f06a1f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.