Closed
Bug 943474
Opened 11 years ago
Closed 10 years ago
Don't print the overall summary for shutdown leak detector failures, since it is redundant
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.69 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
A typical failure found by the new (/reinstated) shutdown leak detector is: { TEST-UNEXPECTED-FAIL | ShutdownLeaks | leaked 2 DOMWindow(s) and 0 DocShell(s) until shutdown TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_url.js | leaked 1 window(s) until shutdown [url = chrome://mozapps/content/xpinstall/xpinstallConfirm.xul] TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_url.js | leaked 1 window(s) until shutdown [url = about:blank] } The first line: * is superfluous noise when using TBPL * encourages people filing intermittent-failure bugs to cram more cruft into the summary than they already do * causes false positives when TBPL searches for the test name "ShutdownLeaks" (I can blacklist this in TBPL, but we should just remove it as it is redundant)
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8338660 -
Flags: review?(ttaubert)
Comment 2•11 years ago
|
||
Comment on attachment 8338660 [details] [diff] [review] Remove summary Review of attachment 8338660 [details] [diff] [review]: ----------------------------------------------------------------- Sounds reasonable to me.
Attachment #8338660 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Ty:-) remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/dcdf76f06a1f
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dcdf76f06a1f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•