943504 - [Gallery] Update Marionette tests to use marionette-file-manager API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Punam Dahiya [:pdahiya]]

Marionette tests in Video and Gallery are using test_common module that queries Gecko for temporary directory and copies a test file there. Bug 936371 created marionette-file-manager plugin for this feature. Scope of this bug is to update Gallery and Video tests to use marionette-file-manager plugin.

Comment 1

[Evan Tseng [:evanxd]]

Hi Punam,

Nice to meet you.
For sharing the info to use marionette-file-manager plugin, we could discuss the below questions you asked me in bugzilla.

1.Need to figure out how to unreserve file manager for subsequent tests.

We should add the marionette-file-manager plugin in https://github.com/mozilla-b2g/gaia/blob/master/shared/test/integration/setup.js

2. I have to manually create, device-storage-testing/videos folder, marionette-file-manager plugin is not able to create these folders in temp directory.

Sorry, bad doc for mariomette-file-manager in https://github.com/mozilla-b2g/marionette-file-manager#usage.

Actually, if we would like to add file into the device-storage-testing/videos directory, we could just do `client.fileManager.add({ type: 'videos', filePath: 'path/to/file1' });` to create the videos directory(if it didn't exist yet) and add a files into it.

3. Also, i have seen the plugin creates file marionetteContentScripts under ~/Library/Caches/TemporaryItems, what's the purpose of this script?

Sorry, I didn't see the file before. Could you upload and show the file here?
Thanks.

Really hope the info could help you. :)

Comment 2

[Evan Tseng [:evanxd]]

Hi Punam,

One more thing.
How do you think if we could add a file in the root directory of device storage(device-storage-testing) with `client.fileManager.add({ filePath: 'path/to/file1' });`(We don't need to give a type, just give the filePath)?

Is it useful for you in the future or now?

Comment 3

[Punam Dahiya [:pdahiya]]

(In reply to Evan Tseng [:evanxd] from comment #1)
> Hi Punam,
> 
> Nice to meet you.
> For sharing the info to use marionette-file-manager plugin, we could discuss
> the below questions you asked me in bugzilla.
> 
> 1.Need to figure out how to unreserve file manager for subsequent tests.
> 
> We should add the marionette-file-manager plugin in
> https://github.com/mozilla-b2g/gaia/blob/master/shared/test/integration/
> setup.js

>> This works now, have update the PR, thanks!
> 
> 2. I have to manually create, device-storage-testing/videos folder,
> marionette-file-manager plugin is not able to create these folders in temp
> directory.
> 
> Sorry, bad doc for mariomette-file-manager in
> https://github.com/mozilla-b2g/marionette-file-manager#usage.
> 
> Actually, if we would like to add file into the
> device-storage-testing/videos directory, we could just do
> `client.fileManager.add({ type: 'videos', filePath: 'path/to/file1' });` to
> create the videos directory(if it didn't exist yet) and add a files into it.
> 
>>>debugged and realised the issue is using  client.fileManager.removeAllFiles(); just before the call to add files  client.fileManager.add([
      { type: 'videos', filePath: 'test_media/Movies/elephants-dream.webm',
        filename: 'elephants-dream.webm' }
            ]);
doesn't work. I have updated the pr with a workaround, which is removing all files in the last test, however  i would prefer to start the video tests with a clean slate and that's why removing all files in temp device storage before adding video files. 

> 3. Also, i have seen the plugin creates file marionetteContentScripts under
> ~/Library/Caches/TemporaryItems, what's the purpose of this script?
> 
> Sorry, I didn't see the file before. Could you upload and show the file here?
>> Attaching the marionetteContentScriptsto the bug, you can replicate it by adding below two statements in a test file, 
    client.fileManager.removeAllFiles();
    client.fileManager.add([
      { type: 'videos', filePath: 'test_media/Movies/elephants-dream.webm',
        filename: 'elephants-dream.webm' }
            ]);

> Thanks.
> 
> Really hope the info could help you. :)

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: marionetteContentScripts

Comment 5

[Punam Dahiya [:pdahiya]]

Thanks Evan for your inputs in Comment 1, it was very helpful. It will help if you can look into why add call fails after removeAllFiles. Let me know if i am missing something here.

Comment 6

[Punam Dahiya [:pdahiya]]

(In reply to Evan Tseng [:evanxd] from comment #2)
> Hi Punam,
> 
> One more thing.
> How do you think if we could add a file in the root directory of device
> storage(device-storage-testing) with `client.fileManager.add({ filePath:
> 'path/to/file1' });`(We don't need to give a type, just give the filePath)?
> 
> Is it useful for you in the future or now?

Its nice to have test files for respective media app in their own sub folders, so if it's possible we would like to keep this feature in the API. Adding file in root directory might be useful in the future.

Comment 7

[Evan Tseng [:evanxd]]

(In reply to Punam Dahiya from comment #5)
> Thanks Evan for your inputs in Comment 1, it was very helpful. It will help
> if you can look into why add call fails after removeAllFiles. Let me know if
> i am missing something here.

Hi Punam,

Excuse me.
Where could I see the patch?

Comment 8

[Punam Dahiya [:pdahiya]]

Hi Evan 

Here's the link to the PR  https://github.com/mozilla-b2g/gaia/pull/14084

Running test video list using: 
bin/gaia-marionette apps/video/test/marionette/video_list_test.js

fails at https://github.com/mozilla-b2g/gaia/pull/14084/files#diff-8fbee53f9fed98efa2896fc5305381edR25
as we have removeAllFiles call before add.


Thanks

Comment 9

[Evan Tseng [:evanxd]]

Hi Punam,

Sorry, for your issues, I found out a bug in marionette-file-manager.
I think I could fix it tomorrow(Taipei time).

Thanks.

Comment 10

[Evan Tseng [:evanxd]]

Bug 948434 is for fixing the issue.

Comment 11

[Evan Tseng [:evanxd]]

Hi Punam,

I already fix the issue and you patch work well.
Please update the package.json to use the new version.

Comment 12

[Evan Tseng [:evanxd]]

as "marionette-file-manager": "0.0.2"

Comment 13

[Punam Dahiya [:pdahiya]]

Awesome, it works! Thanks Evan will update video tests to use marionette-file-manager API.

Comment 14

[Evan Tseng [:evanxd]]

Hi Punam,

If you have time, we could continue to do works for using the marionette-file-manager in the tests for Gallery app.

Thanks. :)

Comment 15

[Punam Dahiya [:pdahiya]]

(In reply to Evan Tseng [:evanxd] from comment #14)
> Hi Punam,
> 
> If you have time, we could continue to do works for using the
> marionette-file-manager in the tests for Gallery app.
> 
> Thanks. :)

Sure, will update Gallery tests as well to use marionette-file-manager API

Comment 16

[Evan Tseng [:evanxd]]

Cool! Thanks. :)

Comment 17

[Punam Dahiya [:pdahiya]]

The fix for this bug is submitted with patch for bug 952706

Comment 18

[Punam Dahiya [:pdahiya]]

Marking the bug resolved as the fix is landed on master with fix of bug 952706