Closed Bug 943579 Opened 11 years ago Closed 11 years ago

override timeout in wait_for_notification_toaster_not_displayed()

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
Other
Linux
Type:
defect

Tracking

(b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: zcampbell, Assigned: viorela)

Details

Attachments

(2 files)

PR: https://github.com/mozilla-b2g/gaia/pull/14116
46 bytes, text/x-github-pull-request
zcampbell
: review+
Details | Review
pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/14126
46 bytes, text/x-github-pull-request
bsilverberg
: review+
Details | Review 
wait_for_notification_toaster_not_displayed() in system/app.py 

If the command line timeout is set to 5 seconds then this method will fail because the notification stays open for over 5 seconds.

Code the timeout of this to be 10 seconds or so, so that it copes better with a variable timeout figure (when issued from the command line).
Assignee: nobody → viorela.ioia

        Attachment #8339175 -
        Flags: review?(zcampbell)

        Attachment #8339175 -
        Flags: review?(florin.strugariu)

        Attachment #8339175 -
        Flags: review?(andrei.hutusoru)

    
    

    
  
Comment on attachment 8339175 [details] [review]
PR: https://github.com/mozilla-b2g/gaia/pull/14116

r+

Merged:
https://github.com/mozilla-b2g/gaia/commit/e1f95f04116970e2e8feef84d7e530efaf1e9266

        Attachment #8339175 -
        Flags: review?(zcampbell)

        Attachment #8339175 -
        Flags: review?(florin.strugariu)

        Attachment #8339175 -
        Flags: review?(andrei.hutusoru)

        Attachment #8339175 -
        Flags: review+

    
  

          status-b2g-v1.2:
          --- → affected

    
    

    
  


  
v1.2

        Attachment #8339250 -
        Flags: review?(trifandreialin)

        Attachment #8339250 -
        Flags: review?(bob.silverberg)

        Attachment #8339250 -
        Flags: review?(andrei.hutusoru)

    
    

    
  
Comment on attachment 8339250 [details] [review]
pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/14126

Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/8164f2cd8c5311b5decb40fccbeaa9c80e9e04a8

        Attachment #8339250 -
        Flags: review?(trifandreialin)

        Attachment #8339250 -
        Flags: review?(bob.silverberg)

        Attachment #8339250 -
        Flags: review?(andrei.hutusoru)

        Attachment #8339250 -
        Flags: review+
Status: NEW → RESOLVED
Closed: 11 years ago

          status-b2g-v1.2:
          affected → fixed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: