Closed
Bug 943596
Opened 9 years ago
Closed 9 years ago
The shader editor highlighting acts weirdly when there's a custom framebuffer attachment on the default renderbuffer
Categories
(DevTools Graveyard :: WebGL Shader Editor, defect, P3)
DevTools Graveyard
WebGL Shader Editor
Tracking
(firefox26 unaffected, firefox27 verified, firefox28 verified)
VERIFIED
FIXED
Firefox 28
Tracking | Status | |
---|---|---|
firefox26 | --- | unaffected |
firefox27 | --- | verified |
firefox28 | --- | verified |
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
3.81 KB,
patch
|
rcampbell
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR: 1. Open Shader Editor on http://david.li/waves/ 2. Hover the "Program {n}" items on the left The rendering starts acting super strange. This is pretty much a followup for bug 938549, where I didn't anticipate that custom framebuffers might be attached to the default renderbuffer, in which case we should suppress highlighting, just like we do when rendering to depth textures.
Assignee | ||
Updated•9 years ago
|
Summary: The shader editor highlighting acts weirdly on http://david.li/waves/ → The shader editor highlighting acts weirdly when there's a custom framebuffer attachment on the default renderbuffer
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8338813 [details] [diff] [review] webgl-highlight-2.patch Review of attachment 8338813 [details] [diff] [review]: ----------------------------------------------------------------- no comment!
Attachment #8338813 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b9250086cf18
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8338813 [details] [diff] [review] webgl-highlight-2.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): This is a very small followup for bug 938549. User impact if declined: Some pages still act weirdly when the Shader Editor is opened (see comment 0). Testing completed (on m-c, etc.): fx-team Risk to taking this patch (and alternatives if risky): None String or IDL/UUID changes made by this patch: None
Attachment #8338813 -
Flags: approval-mozilla-aurora?
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b9250086cf18
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Assignee | ||
Updated•9 years ago
|
status-firefox26:
--- → unaffected
status-firefox27:
--- → affected
status-firefox28:
--- → fixed
Target Milestone: Firefox 28 → ---
Assignee | ||
Updated•9 years ago
|
Target Milestone: --- → Firefox 28
Updated•9 years ago
|
Attachment #8338813 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/08765e9093b6
Assignee | ||
Updated•9 years ago
|
Comment 7•9 years ago
|
||
Verified as fixed using Firefox 27 beta 7 (20140116125114) and latest Aurora 28.0a2 (20140116004003) under Win 7 64-bit, Ubuntu 32-bit and Mac OSX 10.9. Hovering from "Program 0" to "Program 5" had no effect on the waves, hover the "Program 6" changed the animation color.
Updated•5 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•