943619 - Scroll info layers inside an nsDisplayTransform discarded

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Botond Ballo [:botond]]

I ran into a issue today where a scrollable element inside the content process did not have an APZC created for it, even though APZ was enabled.

Some debugging revealed that layout was constructing a scroll info layer for it, but that layer was discarded before making it into the final layer tree. 

I debugged this further with the help of :tn and it turned out the problem has to do with layout's handling of nsDisplayTransform and inactive layer managers.

Comment 1

[Botond Ballo [:botond]]

Attachment: bug943619.patch

This is tn's suggested fix.

Comment 2

[Timothy Nikkel (:tnikkel)]

The expand on that, the problem was that the scroll info layer was created inside an inactive transform, so it got flattened away and never made it to the final layer tree. The problem was that child display items with LAYER_ACTIVE_EMPTY did not force their parents to be active (like LAYER_ACTIVE does).

Comment 3

[Botond Ballo [:botond]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=44be8bbd4b6d

Comment 4

[Botond Ballo [:botond]]

https://hg.mozilla.org/integration/b2g-inbound/rev/039a77740673

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/039a77740673