[email] Two-factor auth password field not localized

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: doliver, Assigned: asuth)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 8338851 [details]
password-two-factor.png

The placeholder text in the Two-Factor password entry screen is not using a localizable string.

STR:
* Set up a gmail account that does NOT have 2-factor auth enabled and successfully sync email
* From your Google account, enable 2-step verification
* Back in FxOS, wait a few minutes and refresh your email 
* you'll be presented with a card informing you that you need to enter an app-specific password. 
* the placeholder text in the entry field is "PassworD". see attached image

* expected: placeholder text should be the localized value of password (can we re-use the string 'setup-info-password' here?)
(Assignee)

Comment 1

5 years ago
Created attachment 8339059 [details] [review]
set the data-l10n-id to be the same as the standard autoconfig password id

There was no data-l10n-id on the node.  I suspect this is somehow a victim of how we previously manually poked placeholders into the DOM using teh codes.
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Attachment #8339059 - Flags: review?(jrburke)
(Assignee)

Comment 2

5 years ago
(and I removed the hard-coded weird-caps placeholder since we don't have one on the main setup screen either.)

Updated

5 years ago
Attachment #8339059 - Flags: review?(jrburke) → review+
(Assignee)

Comment 3

5 years ago
landed:
https://github.com/mozilla-b2g/gaia/pull/14100
https://github.com/mozilla-b2g/gaia/commit/10bd614a7f9b66035e29fb4ee0c5036fe5161465
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.