943620 - [email] Two-factor auth password field not localized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Dylan Oliver [:doliver]]

Attachment: password-two-factor.png

The placeholder text in the Two-Factor password entry screen is not using a localizable string.

STR:
* Set up a gmail account that does NOT have 2-factor auth enabled and successfully sync email
* From your Google account, enable 2-step verification
* Back in FxOS, wait a few minutes and refresh your email 
* you'll be presented with a card informing you that you need to enter an app-specific password. 
* the placeholder text in the entry field is "PassworD". see attached image

* expected: placeholder text should be the localized value of password (can we re-use the string 'setup-info-password' here?)

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: set the data-l10n-id to be the same as the standard autoconfig password id

There was no data-l10n-id on the node.  I suspect this is somehow a victim of how we previously manually poked placeholders into the DOM using teh codes.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

(and I removed the hard-coded weird-caps placeholder since we don't have one on the main setup screen either.)

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

landed:
https://github.com/mozilla-b2g/gaia/pull/14100
https://github.com/mozilla-b2g/gaia/commit/10bd614a7f9b66035e29fb4ee0c5036fe5161465