94371 - nsIPluginStreamListener::GetStreamType is not called anymore

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[sean echevarria]

One of the patches for bug 85334 removed this line in error:
   mPStreamListener->GetStreamType(&mStreamType);

see nsPluginHostImpl.cpp rev 1.271:

http://bonsai.mozilla.org/cvsview2.cgi?
diff_mode=context&whitespace_mode=show&file=nsPluginHostImpl.cpp&root=/cvsroot&s
ubdir=mozilla/modules/plugin/base/src&command=DIFF_FRAMESET&rev1=1.270&rev2=1.27
1

It should either be restored, or the plugin documentation 
(http://www.mozilla.org/docs/plugin.html) should be updated to reflect that all 
streams are treated as nsPluginStreamType_Normal and that 
nsIPluginStreamListener::GetStreamType is no longer called.

Comment 1

[av (gone)]

Peter, did you fix that bug?

Comment 2

[Peter Lubczynski]

Yikes, that needs to go back. But what does the SetUpCache(aURL);              
                                        do?

Comment 3

[av (gone)]

Hm... Looks like it is not used.

Comment 4

[Peter Lubczynski]

Attachment: patch to fix stream type

Comment 5

[Peter Lubczynski]

Sean, how serious is this? Should this be a branch cadidate?

Andrei, can you review?

If the code from SetUpCache(aURL) is no longer needed, another bug should be
opened on removing it.

Comment 6

[av (gone)]

Looks good to me, r=av

Comment 7

[sean echevarria]

Speaking for Beatnik, this isn't serious.  Could be a problem for a plugin if 
it wants nsPluginStreamType_AsFileOnly and doesn't do the right thing in 
OnDataAvailable (which wouldn't normally get called if 
nsPluginStreamType_AsFileOnly was expected).

Comment 8

[Chris Waterson]

SR=WATERSON!!!!!!

Comment 9

[Peter Lubczynski]

Patch in the trunk, marking FIXED.

Comment 10

[shrirang khanzode]

verif patch in trnk.