Closed Bug 94373 Opened 19 years ago Closed 19 years ago
Name conflict: Pref
Changed Callback exists in both layout, and mac gfx, will break Mac static build
A routine called 'PrefChangedCallback' is used in several places to implement preference callbacks: http://lxr.mozilla.org/seamonkey/search?string=PrefChangedCallback. In the Mac static build, we pick up those in /gfx/src/mac/nsUnicodeMappingUtil.cpp and /layout/base/src/nsPresContext.cpp with the result that the static build will behave incorrectly (since the linker will strip out one of those implementatoins). I suggest that both are renamed to be unique.
cc: harishd for P3P use of PrefChangedCallbac, and neeti for PICS usage.
Could I get some review loving here?
[s]r=attinasi for patches to make the callback methods static data members.
I'll take this. ftang: r= on attachment 45129 [details] [diff] [review] please.
Assignee: karnaze → sfraser
Fix checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Since I 'm not exactly sure how to test this, I'm marking verified based on the last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.